From owner-svn-src-all@FreeBSD.ORG Mon Apr 13 06:07:22 2009 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 3535A106572F; Mon, 13 Apr 2009 06:07:22 +0000 (UTC) (envelope-from jfvogel@gmail.com) Received: from wa-out-1112.google.com (wa-out-1112.google.com [209.85.146.182]) by mx1.freebsd.org (Postfix) with ESMTP id AAFBB8FC15; Mon, 13 Apr 2009 06:07:21 +0000 (UTC) (envelope-from jfvogel@gmail.com) Received: by wa-out-1112.google.com with SMTP id m38so1062171waf.27 for ; Sun, 12 Apr 2009 23:07:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:cc:content-type; bh=YVFKth9X9D2BQc9ivkYa07QrtfQzh6vuuenj0werlCM=; b=DjCvQOPHGllu/e4KqCtPq6fWDMaVRiqtWzHo1hLN83Cd2h0+nDbUZdfpF0VvBanM+h 4NdYqhsMUyBwCx20SxvRFTMUyxr8qYe+ez2rOowJf1uIP5Org8BL5yUih8NhckhyJQjJ Vsn/qVARFlvyLBjqUWbG5NyzXrK5kISi2Oy40= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=IgQ6ZHNh4wedzsGaRoFMCYetup3IQxoIBViwt7nGq3IcHeXGQx2AUBz3A69irkZd5U S8LfbLyM+1VL7l5g5xiPrO0EUNfBOnlFNgoIdKaR3HPdVGacte//oGteY7XgPLbg5YoN GI0d8q/8SF88ATHs++jR5Lna7Kd0zn6eGggVE= MIME-Version: 1.0 Received: by 10.115.94.1 with SMTP id w1mr392989wal.177.1239601090626; Sun, 12 Apr 2009 22:38:10 -0700 (PDT) In-Reply-To: References: <200904100005.n3A05lIu025175@svn.freebsd.org> Date: Sun, 12 Apr 2009 22:38:10 -0700 Message-ID: <2a41acea0904122238g86295c5v24a1ab96b37136bd@mail.gmail.com> From: Jack Vogel To: Mike Silbersack Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.5 Cc: Jack F Vogel , svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r190872 - head/sys/dev/e1000 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Apr 2009 06:07:23 -0000 There is quite a bit of shared code changes to support alternate mac addressing, if you look at the diffs you'll notice in attach I inserted a reset, and then also moved where hardware init is called, this is because the shared code now requires RAR(0) to have a valid address in it when it does setup, reset causes that, but init_hardware will zero the RAR array out. I have no idea what your environment is, but it sounds like it may be related. If you have a driver that works, you could try taking the new if_em.* and drop them in, see if that solves it. But right now my guess is this issue is in the shared code and not the core. Let me know what you find, Jack On Sun, Apr 12, 2009 at 10:08 PM, Mike Silbersack wrote: > > Jack, either this or some other recent change to the em driver caused it to > stop working correctly on the e1000 virtual device inside VMware ESX. > Unfortunately, I have not updated my 8.x VMs recently, so I don't know when > this broke. > > I got the message about an invalid MAC address. I modified > em_is_valid_ether_addr to always return True, but it looks like the effect > of that was to cause the driver to load, but give the NIC a MAC of > 00:00:00:00:00:00. However, if I manually set a MAC after that, the virtual > NIC IS functional. So I think the sole problem may just be that the code > which reads the MAC is incompatible with the ESX emulation. > > Do you want me to try a kernel from immediately before this change to > confirm that this was the cause of the problem? > > Mike "Silby" Silbersack > > > On Fri, 10 Apr 2009, Jack F Vogel wrote: > > Author: jfv >> Date: Fri Apr 10 00:05:46 2009 >> New Revision: 190872 >> URL: http://svn.freebsd.org/changeset/base/190872 >> >> Log: >> This delta syncs the em and igb drivers with Intel, >> adds header split and SCTP support into the igb driver. >> Various small improvements and fixes. >> >>