From owner-svn-src-stable-6@FreeBSD.ORG Mon Mar 30 18:47:14 2009 Return-Path: Delivered-To: svn-src-stable-6@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 469AF106564A; Mon, 30 Mar 2009 18:47:14 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c]) by mx1.freebsd.org (Postfix) with ESMTP id 197308FC20; Mon, 30 Mar 2009 18:47:14 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from svn.freebsd.org (localhost [127.0.0.1]) by svn.freebsd.org (8.14.3/8.14.3) with ESMTP id n2UIlDl5075150; Mon, 30 Mar 2009 18:47:13 GMT (envelope-from jhb@svn.freebsd.org) Received: (from jhb@localhost) by svn.freebsd.org (8.14.3/8.14.3/Submit) id n2UIlDGX075147; Mon, 30 Mar 2009 18:47:13 GMT (envelope-from jhb@svn.freebsd.org) Message-Id: <200903301847.n2UIlDGX075147@svn.freebsd.org> From: John Baldwin Date: Mon, 30 Mar 2009 18:47:13 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-6@freebsd.org X-SVN-Group: stable-6 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Subject: svn commit: r190569 - in stable/6/sys: . contrib/pf dev/cxgb dev/twa X-BeenThere: svn-src-stable-6@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for only the 6-stable src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Mar 2009 18:47:15 -0000 Author: jhb Date: Mon Mar 30 18:47:13 2009 New Revision: 190569 URL: http://svn.freebsd.org/changeset/base/190569 Log: MFC: Use a DMA boundary of 4GB to prevent individual transactions from crossing a 4GB address boundary. Due to bus_size_t type limitations, the driver uses a 2GB boundary in PAE kernels. This fixes a data corruption issue when using twa(4) in machines with >= 8 GB of RAM. Modified: stable/6/sys/ (props changed) stable/6/sys/contrib/pf/ (props changed) stable/6/sys/dev/cxgb/ (props changed) stable/6/sys/dev/twa/tw_cl_init.c stable/6/sys/dev/twa/tw_osl.h stable/6/sys/dev/twa/tw_osl_freebsd.c Modified: stable/6/sys/dev/twa/tw_cl_init.c ============================================================================== --- stable/6/sys/dev/twa/tw_cl_init.c Mon Mar 30 18:43:41 2009 (r190568) +++ stable/6/sys/dev/twa/tw_cl_init.c Mon Mar 30 18:47:13 2009 (r190569) @@ -691,7 +691,7 @@ tw_cli_init_connection(struct tw_cli_ctl init_connect->message_credits = TW_CL_SWAP16(message_credits); init_connect->features = TW_CL_SWAP32(set_features); if (ctlr->flags & TW_CL_64BIT_ADDRESSES) - init_connect->features |= TWA_64BIT_SG_ADDRESSES; + init_connect->features |= TW_CL_SWAP32(TWA_64BIT_SG_ADDRESSES); if (set_features & TWA_EXTENDED_INIT_CONNECT) { /* * Fill in the extra fields needed for an extended Modified: stable/6/sys/dev/twa/tw_osl.h ============================================================================== --- stable/6/sys/dev/twa/tw_osl.h Mon Mar 30 18:43:41 2009 (r190568) +++ stable/6/sys/dev/twa/tw_osl.h Mon Mar 30 18:47:13 2009 (r190569) @@ -55,6 +55,12 @@ //#define TW_OSLI_DEFERRED_INTR_USED +#ifdef PAE +#define TW_OSLI_DMA_BOUNDARY (1u << 31) +#else +#define TW_OSLI_DMA_BOUNDARY ((bus_size_t)((uint64_t)1 << 32)) +#endif + /* Possible values of req->state. */ #define TW_OSLI_REQ_STATE_INIT 0x0 /* being initialized */ #define TW_OSLI_REQ_STATE_BUSY 0x1 /* submitted to CL */ Modified: stable/6/sys/dev/twa/tw_osl_freebsd.c ============================================================================== --- stable/6/sys/dev/twa/tw_osl_freebsd.c Mon Mar 30 18:43:41 2009 (r190568) +++ stable/6/sys/dev/twa/tw_osl_freebsd.c Mon Mar 30 18:47:13 2009 (r190569) @@ -484,7 +484,7 @@ tw_osli_alloc_mem(struct twa_softc *sc) /* Create the parent dma tag. */ if (bus_dma_tag_create(NULL, /* parent */ sc->alignment, /* alignment */ - 0, /* boundary */ + TW_OSLI_DMA_BOUNDARY, /* boundary */ BUS_SPACE_MAXADDR, /* lowaddr */ BUS_SPACE_MAXADDR, /* highaddr */ NULL, NULL, /* filter, filterarg */ @@ -1324,7 +1324,7 @@ static TW_VOID twa_map_load_callback(TW_VOID *arg, bus_dma_segment_t *segs, TW_INT32 nsegments, TW_INT32 error) { - *((bus_addr_t *)arg) = segs[0].ds_addr; + *((TW_UINT64 *)arg) = segs[0].ds_addr; }