Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 15 Jun 2013 13:06:06 +0400
From:      Boris Samorodov <bsam@passap.ru>
To:        bapt <bapt@etoilbsd.net>
Cc:        svn-ports-head@freebsd.org, Baptiste Daroussin <bapt@FreeBSD.org>, bapt <baptiste.daroussin@gmail.com>, svn-ports-all@freebsd.org, ports-committers@freebsd.org
Subject:   Re: RE : Re: svn commit: r320973 - head/audio/grip
Message-ID:  <51BC2E7E.8030605@passap.ru>
In-Reply-To: <kqcoep27lv3xn9u9fa53omnt.1371285299440@email.android.com>
References:  <kqcoep27lv3xn9u9fa53omnt.1371285299440@email.android.com>

next in thread | previous in thread | raw e-mail | index | archive | help
(email reformatted)

15.06.2013 12:35, bapt пишет:
> Envoyé depuis mon mobile OrangeBoris Samorodov <bsam@passap.ru> a écrit :
15.06.2013 02:31, Baptiste Daroussin пишет:
> 
>> Log:
>>    Use new options helpers
>>
>> Modified:
>>    head/audio/grip/Makefile
>>
> [...]
>>   LIB_DEPENDS=	id3-3.8.3:${PORTSDIR}/audio/id3lib \
>> -	 curl.6:${PORTSDIR}/ftp/curl
>> +	 curl:${PORTSDIR}/ftp/curl
> 
> Was this change intended?
> If yes, I think the change is worth PORTREVISION bumping.
> 
> The package hasn t changed so no need for a bump

I appreciate your answer, thanks. But i'm not sure if you understood
what I had ment.

The shlib ABI version was removed from LIB_DEPENDS and it was not
reflected at the log. So the question arises if it was intended.
Imho (yep, it's really imho) this change is seriuos enough to go
to the log.

Working with ports sometimes driving me nuts while searching
a particular commit (or even if it ever existed). Well, removing
makefile headers may be left out as well as some other info.
But imho not this case.

Second, the package definitely had changed. The dependency had
changed from libcurl.so.6 to libcurl.so. And this is recorded
at the package.

But in this case the dependency happens to become more wide
(i.e. all library version will fit it). While the case with
opposite direction (when LIB_DEPENDS converts from *.so to
*.so.X) is more clear to me (the bump is vital) current case
is not so clear to me.

Thanks.
-- 
WBR, Boris Samorodov (bsam)
FreeBSD Committer, http://www.FreeBSD.org The Power To Serve



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?51BC2E7E.8030605>