From owner-cvs-ports@FreeBSD.ORG Mon Jan 21 20:45:05 2008 Return-Path: Delivered-To: cvs-ports@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4A28C16A41A for ; Mon, 21 Jan 2008 20:45:05 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from mail2.fluidhosting.com (mx21.fluidhosting.com [204.14.89.4]) by mx1.freebsd.org (Postfix) with SMTP id DB84D13C503 for ; Mon, 21 Jan 2008 20:45:04 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: (qmail 30344 invoked by uid 399); 21 Jan 2008 20:45:04 -0000 Received: from localhost (HELO ?192.168.0.4?) (dougb@dougbarton.us@127.0.0.1) by localhost with ESMTP; 21 Jan 2008 20:45:04 -0000 X-Originating-IP: 127.0.0.1 Message-ID: <4795044E.6030006@FreeBSD.org> Date: Mon, 21 Jan 2008 12:45:02 -0800 From: Doug Barton Organization: http://www.FreeBSD.org/ User-Agent: Thunderbird 2.0.0.9 (Windows/20071031) MIME-Version: 1.0 To: Rong-En Fan References: <200801200837.m0K8bNX0081391@repoman.freebsd.org> In-Reply-To: <200801200837.m0K8bNX0081391@repoman.freebsd.org> X-Enigmail-Version: 0.95.6 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/sysutils/LPRng Makefile distinfo pkg-descr pkg-plist ports/sysutils/LPRng/files lprng.in pkg-message.in X-BeenThere: cvs-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Jan 2008 20:45:05 -0000 Rong-En Fan wrote: > rafan 2008-01-20 08:37:23 UTC > > FreeBSD ports repository > > Modified files: > sysutils/LPRng Makefile distinfo pkg-descr pkg-plist > sysutils/LPRng/files pkg-message.in > Added files: > sysutils/LPRng/files lprng.in > Log: > - Update to 3.8.32 > - Provide new rc script The script looks good, thanks for doing this! The only thing I would point out is that the default _enable=no is not needed, since rc.subr needs to see one of the values for "yes" in order to do anything. No harm leaving it in, I just wanted to point out that it's not strictly necessary. Doug -- This .signature sanitized for your protection