From owner-svn-src-all@freebsd.org Fri Feb 10 21:05:06 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 076C6CD94F7; Fri, 10 Feb 2017 21:05:06 +0000 (UTC) (envelope-from carpeddiem@gmail.com) Received: from mail-io0-x241.google.com (mail-io0-x241.google.com [IPv6:2607:f8b0:4001:c06::241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id C4A8DA72; Fri, 10 Feb 2017 21:05:05 +0000 (UTC) (envelope-from carpeddiem@gmail.com) Received: by mail-io0-x241.google.com with SMTP id 101so6948318iom.0; Fri, 10 Feb 2017 13:05:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=UFAHL2rYpnNYqP/+VTaHBQiHy5RTfvvDbcRrpQjhf6I=; b=Ks+DNeU2oUsoWIPCLBcj/ONhoVYATvXDhI5V7qOHG5RUPiyw7mVCsUy5q89k8puPTU GnT9eEjvVfm2kzx1xu9jclJwN6nIbEV9to2qj48fSSuGucwEKyjlr5b8qKnLHA+6I6j0 spAFrh2RPAjpNzDqH9utMt7hASzzuSi+dtzvF1l7liVJoAYVDJ/1T7FLXCxWxIzcU0qi utqqbUy9v1qG7zmrWNyvB+NcWPVflY2EX7GO4yvg4RpW9eL/ccmcLztfocoTMZ7xAB2Y qH/rCXJM4j6jRaIPbouanB6aWdNAnxe3WWrLF48xc4zy1u2X8EzMs5knSeqZ2o6oO47j HDWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=UFAHL2rYpnNYqP/+VTaHBQiHy5RTfvvDbcRrpQjhf6I=; b=mROPOIxxVedGGAbRL6E8IWChC/5Eg0JrZEGYgLdpf1R3HgF9xZ6fU3ucHhRTuVeTpv tEP65ThijUII5tTYtf9IldCu1NT8aOfGLMYJqtnI6qpSekTyRQ6HsUolxC+OPu9gtlmb CCyPLc5LS+Jw/l3DjjlPJJW1aTM1W/AdhbpMF+ZqEzZ0St5mdioLxj4hI0cEDUl1kbol KBkz7VUHpyAGR9GQuslmxQ03/gzt44lzU9UKo8hKXU3LFTCWEpf16MDT3DvjopIKlkg7 aPzv8mQOIj+dWYKHzz+abBihnD6JTSFoMsCQ0GgV9Jz0j1oIADLCWhdBWEtcwJXCSkal VV2g== X-Gm-Message-State: AMke39ndpl0Cigi6t4qrzfHA4DlGYS/t3VUGMXGG1yYiQ+Njf7N+gaA9MutoXw+8TeS8zbLNE+01NsHzXdfICQ== X-Received: by 10.107.142.195 with SMTP id q186mr4841580iod.169.1486760705099; Fri, 10 Feb 2017 13:05:05 -0800 (PST) MIME-Version: 1.0 Sender: carpeddiem@gmail.com Received: by 10.107.175.159 with HTTP; Fri, 10 Feb 2017 13:04:44 -0800 (PST) In-Reply-To: <20170210201008.GG1973@FreeBSD.org> References: <201702071857.v17Ivvn1018291@repo.freebsd.org> <20170210201008.GG1973@FreeBSD.org> From: Ed Maste Date: Fri, 10 Feb 2017 16:04:44 -0500 X-Google-Sender-Auth: NFHBEXyQlGc8OgFGVOa3KgbRYlY Message-ID: Subject: Re: svn commit: r313401 - head/sys/netinet To: Gleb Smirnoff Cc: Eric van Gyzen , "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Feb 2017 21:05:06 -0000 On 10 February 2017 at 15:10, Gleb Smirnoff wrote: > > Thanks. I think inet_ntoa() and anything that uses static buffer > should just be removed from libkern. Agreed. A quick grep found inet_ntoa used in: netpfil/pf/pf_osfp.c netpfil/ipfw/ip_fw_log.c kern/kern_jail.c fs/nfsserver/nfs_nfsdkrpc.c netinet/ip_icmp.c netinet/tcp_hostcache.c netinet/ip_options.c netinet/in_mcast.c netinet/igmp.c netinet/libalias/alias_nbt.c netinet/libalias/alias_proxy.c netinet/libalias/alias_sctp.c netinet/ip_mroute.c netinet/in.c netinet/if_ether.c dev/cxgb/ulp/iw_cxgb/iw_cxgb_cm.c