Date: Fri, 12 Sep 2014 09:41:19 +0200 From: Tijl Coosemans <tijl@FreeBSD.org> To: Gerald Pfeifer <gerald@pfeifer.com> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, Dmitry Marakasov <amdmi3@amdmi3.ru>, ports-committers@freebsd.org Subject: Re: svn commit: r367888 - in head: accessibility/accerciser accessibility/jovie accessibility/kaccessible accessibility/kdeaccessibility4 accessibility/kmag accessibility/kmousetool accessibility/kmout... Message-ID: <20140912094119.65e8c500@kalimero.tijl.coosemans.org> In-Reply-To: <alpine.LSU.2.11.1409120201290.2669@tuna.site> References: <201409102050.s8AKobw3056642@svn.freebsd.org> <20140911000146.GO43982@hades.panopticon> <20140911001739.GP43982@hades.panopticon> <alpine.LSU.2.11.1409110220490.2867@tuna.site> <20140911171600.6c6527c5@kalimero.tijl.coosemans.org> <alpine.LSU.2.11.1409120201290.2669@tuna.site>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, 12 Sep 2014 02:24:42 +0200 (CEST) Gerald Pfeifer <gerald@pfeifer.com> wrote:
> On Thu, 11 Sep 2014, Tijl Coosemans wrote:
>> devel/kBuild wasn't bumped either (reported on emulation@).
>
> I looked into this, and so far have not been able to see why
> Tools/scripts/bump_revision.pl did not catch this one.
I suspect it's the INDEX file. It doesn't record a dependency on gcc
for USE_GCC=any, probably because it isn't generated on FreeBSD 10, but
even if it was it wouldn't be correct for arm and powerpc. The only
reliable way is to grep the tree, in this case for "lang/gcc", "USE_GCC"
and "compiler:*" knobs that may select gcc.
> In some other cases, ports were a bit more creative than I'd
> usually recommend, using a pattern like the following:
>
> PORTREVISION?= ${XORG_REVISION}
> :
> .if defined(WITH_NEW_XORG)
> XORG_REVISION= 8
> :
> .else
> XORG_REVISION= 13
> :
> .endif
>
> Good luck handling things like that with a simple script.
>
> If it were me, I'd just make this port XORG_REVISION=13 for
> both branches, and thus simplify this. I am not sure the
> complexity here is worth it.
Yeah, the script should print an error message if it cannot bump a port.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20140912094119.65e8c500>