From owner-svn-ports-all@FreeBSD.ORG  Fri Sep 12 07:41:23 2014
Return-Path: <owner-svn-ports-all@FreeBSD.ORG>
Delivered-To: svn-ports-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id A78B4426;
 Fri, 12 Sep 2014 07:41:23 +0000 (UTC)
Received: from mailrelay004.isp.belgacom.be (mailrelay004.isp.belgacom.be
 [195.238.6.170]) by mx1.freebsd.org (Postfix) with ESMTP id E842081B;
 Fri, 12 Sep 2014 07:41:22 +0000 (UTC)
X-Belgacom-Dynamic: yes
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: Am4GAKmiElRR8a8O/2dsb2JhbABggw1TV8hgh1IBgQ4XeIQDAQEBAwE6HCMFCwsYCRoLDyoeBhOIOgwBviEBF49NB4RMAQSWAIcClTyCG4FIOy+CTwEBAQ
Received: from 14.175-241-81.adsl-dyn.isp.belgacom.be (HELO
 kalimero.tijl.coosemans.org) ([81.241.175.14])
 by relay.skynet.be with ESMTP; 12 Sep 2014 09:41:20 +0200
Received: from kalimero.tijl.coosemans.org (kalimero.tijl.coosemans.org
 [127.0.0.1])
 by kalimero.tijl.coosemans.org (8.14.9/8.14.9) with ESMTP id s8C7fJiA001130;
 Fri, 12 Sep 2014 09:41:19 +0200 (CEST)
 (envelope-from tijl@FreeBSD.org)
Date: Fri, 12 Sep 2014 09:41:19 +0200
From: Tijl Coosemans <tijl@FreeBSD.org>
To: Gerald Pfeifer <gerald@pfeifer.com>
Subject: Re: svn commit: r367888 - in head: accessibility/accerciser
 accessibility/jovie accessibility/kaccessible
 accessibility/kdeaccessibility4 accessibility/kmag accessibility/kmousetool
 accessibility/kmout...
Message-ID: <20140912094119.65e8c500@kalimero.tijl.coosemans.org>
In-Reply-To: <alpine.LSU.2.11.1409120201290.2669@tuna.site>
References: <201409102050.s8AKobw3056642@svn.freebsd.org>
 <20140911000146.GO43982@hades.panopticon>
 <20140911001739.GP43982@hades.panopticon>
 <alpine.LSU.2.11.1409110220490.2867@tuna.site>
 <20140911171600.6c6527c5@kalimero.tijl.coosemans.org>
 <alpine.LSU.2.11.1409120201290.2669@tuna.site>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org,
 Dmitry Marakasov <amdmi3@amdmi3.ru>, ports-committers@freebsd.org
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 12 Sep 2014 07:41:23 -0000

On Fri, 12 Sep 2014 02:24:42 +0200 (CEST) Gerald Pfeifer <gerald@pfeifer.com> wrote:
> On Thu, 11 Sep 2014, Tijl Coosemans wrote:
>> devel/kBuild wasn't bumped either (reported on emulation@).
> 
> I looked into this, and so far have not been able to see why
> Tools/scripts/bump_revision.pl did not catch this one.

I suspect it's the INDEX file.  It doesn't record a dependency on gcc
for USE_GCC=any, probably because it isn't generated on FreeBSD 10, but
even if it was it wouldn't be correct for arm and powerpc.  The only
reliable way is to grep the tree, in this case for "lang/gcc", "USE_GCC"
and "compiler:*" knobs that may select gcc.

> In some other cases, ports were a bit more creative than I'd
> usually recommend, using a pattern like the following:
> 
>     PORTREVISION?= ${XORG_REVISION}
>     :
>     .if defined(WITH_NEW_XORG)
>      XORG_REVISION= 8
>      :
>      .else
>      XORG_REVISION= 13
>      :
>      .endif
> 
> Good luck handling things like that with a simple script.
> 
> If it were me, I'd just make this port XORG_REVISION=13 for
> both branches, and thus simplify this.  I am not sure the
> complexity here is worth it.

Yeah, the script should print an error message if it cannot bump a port.