Date: Sat, 28 May 2016 01:39:42 +0300 From: Konstantin Belousov <kostikbel@gmail.com> To: "Ngie Cooper (yaneurabeya)" <yaneurabeya@gmail.com> Cc: Alan Cox <alc@rice.edu>, Ivan Klymenko <fidaj@ukr.net>, Alan Cox <alc@FreeBSD.org>, src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r300865 - in head/sys: sys vm Message-ID: <20160527223942.GS38613@kib.kiev.ua> In-Reply-To: <05E6AFC6-E7B4-45E9-8E5B-C2CDA439D33B@gmail.com> References: <201605271915.u4RJFkEl013139@repo.freebsd.org> <20160527225103.67ae3547@nonamehost.local> <20160527210148.GR38613@kib.kiev.ua> <016BEE0D-05B6-4042-8CD4-471D4D1C9162@gmail.com> <3018B8E4-5E33-49EF-8154-D7D5ECEE8403@gmail.com> <5CAD8DF0-0D56-4EBD-AB93-645B21E3792D@gmail.com> <4318dffc-fef5-2128-74c2-0e97767b36c8@rice.edu> <05E6AFC6-E7B4-45E9-8E5B-C2CDA439D33B@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, May 27, 2016 at 03:32:48PM -0700, Ngie Cooper (yaneurabeya) wrote: > > > On May 27, 2016, at 14:26, Alan Cox <alc@rice.edu> wrote: > > > > On 05/27/2016 16:22, Ngie Cooper (yaneurabeya) wrote: > >>> On May 27, 2016, at 14:21, Ngie Cooper (yaneurabeya) <yaneurabeya@gmail.com> wrote: > >>>> I added #include <sys/types.h> to zfs/arc.c in r300870 ??? it was missing from the file. Looking into drm2 and fed. > >>> Oy. Bad test before I did the fix. The issue was libzpool -_- (just saw alc???s comment)??? I???ll fix my commit.. > >> Actually, I???ll just revert my commit and report back about whether or not your patch worked kib. > > > > > > Revert and remove the vm_pageout.h #include from arc.c. > > Confirmed. Reverting r300870 and applying kib???s diff passes buildworld. Please commit the patch. There was Alan' suggestion to remove vm_pageout.h at all. Either way, commit my patch, or preferrably Alan' suggested changes yourself.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20160527223942.GS38613>