Date: Fri, 12 Oct 2018 14:55:38 -0600 From: Sean Bruno <sbruno@freebsd.org> To: Mathieu Arnold <mat@FreeBSD.org> Cc: Tobias Kortkamp <tobik@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r481915 - in head/sysutils/ipmitool: . files Message-ID: <7010c7ad-24a6-fadd-ae7e-8623d827e066@freebsd.org> In-Reply-To: <20181012201057.rhvyjebk5rjb5jcu@atuin.in.mat.cc> References: <201810121751.w9CHpbfM070987@repo.freebsd.org> <1539367083.328758.1540102872.2C88E8B9@webmail.messagingengine.com> <530dca2f-e668-3c5b-9c91-346ebda2366f@freebsd.org> <20181012201057.rhvyjebk5rjb5jcu@atuin.in.mat.cc>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --BduBcEQOPssrMJ7nTIwMQs96DC9mMWjLp Content-Type: multipart/mixed; boundary="pDv6ZokKK6w0mf9SjhtHGT78a7eE5bzlQ"; protected-headers="v1" From: Sean Bruno <sbruno@freebsd.org> To: Mathieu Arnold <mat@FreeBSD.org> Cc: Tobias Kortkamp <tobik@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Message-ID: <7010c7ad-24a6-fadd-ae7e-8623d827e066@freebsd.org> Subject: Re: svn commit: r481915 - in head/sysutils/ipmitool: . files References: <201810121751.w9CHpbfM070987@repo.freebsd.org> <1539367083.328758.1540102872.2C88E8B9@webmail.messagingengine.com> <530dca2f-e668-3c5b-9c91-346ebda2366f@freebsd.org> <20181012201057.rhvyjebk5rjb5jcu@atuin.in.mat.cc> In-Reply-To: <20181012201057.rhvyjebk5rjb5jcu@atuin.in.mat.cc> --pDv6ZokKK6w0mf9SjhtHGT78a7eE5bzlQ Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 10/12/18 2:10 PM, Mathieu Arnold wrote: > So, you want us to add something like "if the variable EXTRA_PATCHES is= > already set before, instead of using =3D, use +=3D"? >=20 > I don't really see it happening, we are not going to state all the > possible cases, the porter's handbook would end up being ISO9001 and 50= k > pages long, we assume that you know make(1), so that when you add a > variable, you actually look for it in the Makefile to see if it is not > already set. I don't think I'm asking for that. I think I'm asking for "we should have the example be a +=3D instead of a= =3D" because of the DOCS variable and how it behaves. EXTRA_PATCHES wasn't in use in this example before I added the openssl1.1.1 patch abomination, but I guess, DOCS implicitly means its always in use. Because of this behavior, I'm asking that the porter's handbook be changed as that's what I used to generate the update in the first place and due to the behavior of DOCS, it would have made things misbehave. At least, that's how I understand the request. sean --pDv6ZokKK6w0mf9SjhtHGT78a7eE5bzlQ-- --BduBcEQOPssrMJ7nTIwMQs96DC9mMWjLp Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQGTBAEBCgB9FiEE6MTp+IA1BOHj9Lo0veT1/om1/LYFAlvBCkpfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEU4 QzRFOUY4ODAzNTA0RTFFM0Y0QkEzNEJERTRGNUZFODlCNUZDQjYACgkQveT1/om1 /LbK8gf/btOeTo1DKy6qyXCYc9ZL3pL3t1pCuav+y8jtbcu2qJJ+/hNSdG92hdQz tcprhn1UZu9/7nTWph0a8AJFnc+lt6nUToZoXX2DD48PlHh7nk+VlIcO0tMW3p6a YanYRowoO+k6vMYenPTeDMTsXAJN/NASOfNebxMP5saRtfpX1HLZUiP8gfYWYL7Y CIji/A9NxQj9XK902VumjdMBKcGiLXJTSuHuff2AuMdtXDk28VkGCneE1bY86M2O TiWOa7Z6pbeug5n05oYNGZgCWE9Rufp4d68bioQQxNWBu55gv5yQ6yNoJfWsmLtX +368q5AsX/kE/4hV9nRCKWctB879/g== =BhDZ -----END PGP SIGNATURE----- --BduBcEQOPssrMJ7nTIwMQs96DC9mMWjLp--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?7010c7ad-24a6-fadd-ae7e-8623d827e066>