Date: Fri, 12 Jan 2018 10:26:41 +0100 From: Baptiste Daroussin <bapt@FreeBSD.org> To: Kurt Jaeger <pi@FreeBSD.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r458811 - head/x11-fonts/encodings Message-ID: <20180112092641.kb7m66ffkli7opt7@ivaldir.net> In-Reply-To: <201801120916.w0C9GKE4036634@repo.freebsd.org> References: <201801120916.w0C9GKE4036634@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--pgqto4alxwaqvjju Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jan 12, 2018 at 09:16:20AM +0000, Kurt Jaeger wrote: > Author: pi > Date: Fri Jan 12 09:16:20 2018 > New Revision: 458811 > URL: https://svnweb.freebsd.org/changeset/ports/458811 >=20 > Log: > x11-fonts/encodings: run mkfontscale to fix encodings.dir post-install > =20 > - Since only *.enc.gz files are installed while the encodings.dir file = is > genareted for directories containing both *.enc and *.enc.gz files, > the installed encodings.dir file includes bogus entries for *.enc. > - It causes libfontenc to fail to find encoding files, then X to fail to > open TrueType fonts with some encodings such as ascii-0 or jisx0208.1= 990-0. > =20 > PR: 170852 > Submitted by: hiroto.kagotani@gmail.com, Jia-Shiun Li <jiashiun@gmail.c= om> >=20 > Modified: > head/x11-fonts/encodings/Makefile > head/x11-fonts/encodings/pkg-descr >=20 > Modified: head/x11-fonts/encodings/Makefile > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/x11-fonts/encodings/Makefile Fri Jan 12 09:03:49 2018 (r458810) > +++ head/x11-fonts/encodings/Makefile Fri Jan 12 09:16:20 2018 (r458811) > @@ -2,18 +2,24 @@ > =20 > PORTNAME=3D encodings > PORTVERSION=3D 1.0.4 > -PORTREVISION=3D 3 > +PORTREVISION=3D 4 > PORTEPOCH=3D 1 > -MASTER_SITES=3D XORG/individual/font > CATEGORIES=3D x11-fonts > +MASTER_SITES=3D XORG/individual/font > =20 > MAINTAINER=3D x11@FreeBSD.org > COMMENT=3D X.Org Encoding fonts > =20 > +LICENSE=3D PD > + > +BUILD_DEPENDS=3D mkfontscale:x11-fonts/mkfontscale > + > USES=3D tar:bzip2 > USE_XORG=3D fontutil > -BUILD_DEPENDS=3D mkfontscale:x11-fonts/mkfontscale > GNU_CONFIGURE=3D yes > CONFIGURE_ARGS=3D --with-fontrootdir=3D${PREFIX}/share/fonts > + > +post-install: > + cd ${STAGEDIR}/usr/local/share/fonts/encodings && /usr/local/bin/mkfont= scale -b -s -l -n -r -p /usr/local/share/fonts/encodings -e . -e large . > =20 No no no no no never ever hard code /usr/local It should be either: cd ${STAGEDIR}${PREFIX}/share/fonts/encodings && ${LOCALBASE}/bin/mkfontsca= le -b -s -l -n -r -p ${PREFIX}/share/fonts/encodings -e . -e large . Also why not trusting PATH here? Given how the BUILD dependency is looked u= p you are sure mkfontscale is in the path anyway cd ${STAGEDIR}${PREFIX}/share/fonts/encodings && mkfontscale -b -s -l -n -r -p ${PREFIX}/share/fonts/encodings -e . -e large . Best regards, Bapt --pgqto4alxwaqvjju Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEgOTj3suS2urGXVU3Y4mL3PG3PloFAlpYf04ACgkQY4mL3PG3 Plq+Pw//af160fMjZJb4/hsyvI8w/Rhoxx9jez2hYLntR37FkttmtF3grhH+Nu5C ao9pxAgO/MQoLltCnkONINxUSx0I2ruin6SZl2rp7su21wmx/EMVSzd5GcLsIqj1 jwFmVfUayFz+P2JD2S3gi0P1sQK1QlmW3QmkmwGntIQQNWEHJXaUZkezHChp5p67 S/hv6mvJlyfFWdG/I7PEn5wJ77UCcyv2uwLGSHDZAMwqQncvkTJiavUbLX+1nlS+ poNNZSLya9WnIt3zSUb2C7WwWlc2OIr3Ydf7MEqQFb+Mf4uhUSIxakixMVCCFzeR HBPsAdGKm14vo4k9ZrmYUZPSsEufIKEAVNADCia+Sm8kWJDUNYiEL+CfYZwpC08v V6LT6+U73B04hVX2dHEFplCXL1XImcrPENO6f53OiMzu+s3VsPTN3A+QYIH4O7iR psgPzkYluQFdziR1B1Vz1ufI/Kt71HQgj5b8yrqlWFHrakMN9k9hmsWmPnYfvVrF zMnA7KvMXlXMUZfg5m86lRFNqjXfze80XHUUaReks5WwOpiy3EImTCThXcfyBXfl atr5l/6N9ZbP48KFjm08bMoLP2QWH8vCNaj0Jt++Q39BDHpnzzz+dQZE+S1Qm0NA hPMMupE10nNcAhOf+qkw7v4PU/UoOSmS8kbXLVYywFKx1ToQkr0= =Q43Q -----END PGP SIGNATURE----- --pgqto4alxwaqvjju--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20180112092641.kb7m66ffkli7opt7>