Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 22 Jan 2017 05:49:43 +0000 (UTC)
From:      Justin Hibbits <jhibbits@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r312613 - head/sys/powerpc/mpc85xx
Message-ID:  <201701220549.v0M5nhDf045612@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: jhibbits
Date: Sun Jan 22 05:49:43 2017
New Revision: 312613
URL: https://svnweb.freebsd.org/changeset/base/312613

Log:
  Fix use of uninitialized variable.
  
  I don't know how gcc didn't catch this.  This was caught during test building
  with clang.

Modified:
  head/sys/powerpc/mpc85xx/fsl_diu.c

Modified: head/sys/powerpc/mpc85xx/fsl_diu.c
==============================================================================
--- head/sys/powerpc/mpc85xx/fsl_diu.c	Sun Jan 22 05:45:42 2017	(r312612)
+++ head/sys/powerpc/mpc85xx/fsl_diu.c	Sun Jan 22 05:49:43 2017	(r312613)
@@ -344,7 +344,7 @@ diu_init(struct diu_softc *sc)
 static int
 diu_attach(device_t dev)
 {
-	struct edid_info *edid;
+	struct edid_info edid;
 	struct diu_softc *sc;
 	const struct videomode *videomode;
 	void *edid_cells;
@@ -384,7 +384,7 @@ diu_attach(device_t dev)
 		}
 	}
 	if (edid_cells != NULL) {
-		if (edid_parse(edid_cells, edid) != 0) {
+		if (edid_parse(edid_cells, &edid) != 0) {
 			device_printf(dev, "Error parsing EDID\n");
 			OF_prop_free(edid_cells);
 			return (ENXIO);



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201701220549.v0M5nhDf045612>