From owner-freebsd-fs@FreeBSD.ORG Mon Sep 27 16:12:38 2010 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7D038106564A for ; Mon, 27 Sep 2010 16:12:38 +0000 (UTC) (envelope-from gljennjohn@googlemail.com) Received: from mail-fx0-f54.google.com (mail-fx0-f54.google.com [209.85.161.54]) by mx1.freebsd.org (Postfix) with ESMTP id 0429A8FC14 for ; Mon, 27 Sep 2010 16:12:37 +0000 (UTC) Received: by fxm9 with SMTP id 9so3746236fxm.13 for ; Mon, 27 Sep 2010 09:12:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=gamma; h=domainkey-signature:received:received:date:from:to:cc:subject :message-id:in-reply-to:references:reply-to:x-mailer:mime-version :content-type:content-transfer-encoding; bh=2fKP+WSswqpLH4tDTFPmeuAveSr1kuZ2qfc/AGE3GVw=; b=dYGLrL4i2ByURrP5aKgCvocADISbCpTISQuS4n5iE5ybPDdmTtTrUCeRy0k/JRU/6G Av6FXjj+i1hQwv93SRQ7p5P6vHOiloD5BKNsMUbJRGpwZ1leGN/BaACi8ZWuyi3sVGpk xwHCiNaMf5yMzoJnPxWNXiL8hBX+PEuSVDRD0= DomainKey-Signature: a=rsa-sha1; c=nofws; d=googlemail.com; s=gamma; h=date:from:to:cc:subject:message-id:in-reply-to:references:reply-to :x-mailer:mime-version:content-type:content-transfer-encoding; b=wVurB1pNVV8K9bcbX4Yr4wDHA/yMnVLT2C5sVXS+j4R2PZm6D5OKy00ij9swtou9mo /CTY89a6uYd6tSd7AzhNWl9ETpVodGBAwmYTeLlG9JZAnFWyoGYb8WDRZuJemgMrvGzl +JCs/jLenkHaplfVzK8c5q5StIdrjsvCjsrxs= Received: by 10.223.120.72 with SMTP id c8mr3500278far.65.1285603956860; Mon, 27 Sep 2010 09:12:36 -0700 (PDT) Received: from ernst.jennejohn.org (p578E3B24.dip.t-dialin.net [87.142.59.36]) by mx.google.com with ESMTPS id r8sm2507997faq.34.2010.09.27.09.12.35 (version=TLSv1/SSLv3 cipher=RC4-MD5); Mon, 27 Sep 2010 09:12:35 -0700 (PDT) Date: Mon, 27 Sep 2010 18:12:33 +0200 From: Gary Jennejohn To: Michael Naef Message-ID: <20100927181233.0e8c2869@ernst.jennejohn.org> In-Reply-To: <201009271624.46655.cal@linu.gs> References: <201009231938.09548.cal@linu.gs> <66757A1E-E445-4AAD-8F57-382D85BFD579@hostpoint.ch> <201009271624.46655.cal@linu.gs> X-Mailer: Claws Mail 3.7.6 (GTK+ 2.18.7; amd64-portbld-freebsd9.0) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: freebsd-fs Subject: Re: Strange behaviour with sappend flag set on ZFS X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: gljennjohn@googlemail.com List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Sep 2010 16:12:38 -0000 On Mon, 27 Sep 2010 16:24:42 +0200 Michael Naef wrote: > Hi all > > On Friday 24 September 2010 01:15:55 Markus Gebert wrote: > > > CURRENT and STABLE-8 seem to be affected to. The following patch > > seems to fix it (at least Michi's test case works fine with > > it): > > > > ---- > > diff -ru > > ../src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_vnops > > .c ./sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_vnops.c > > --- > > ../src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_vnops > > .c 2010-05-19 08:49:52.000000000 +0200 +++ > > ./sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_vnops.c > > 2010-09-23 23:24:43.549846948 +0200 @@ -709,7 +709,7 @@ > > */ > > pflags = zp->z_phys->zp_flags; > > if ((pflags & (ZFS_IMMUTABLE | ZFS_READONLY)) || > > - ((pflags & ZFS_APPENDONLY) && !(ioflag & FAPPEND) && > > + ((pflags & ZFS_APPENDONLY) && !(ioflag & IO_APPEND) > > && (uio->uio_loffset < zp->z_phys->zp_size))) { > > ZFS_EXIT(zfsvfs); > > return (EPERM); > > ---- > > > > Can someone commit this if the patch is ok? Or should I (or > > Michi) open a PR? > > Whats the next step? Is anyboby willing and able to commit the > patch or should/must I open a PR? (Having a patch for bash which > solves the most urgent problem, though - but I need a decision.) > Sending a PR is always a good idea - it ends up in the tracking system and doesn't get lost in the mailing-list noise. -- Gary Jennejohn