From owner-freebsd-arm@FreeBSD.ORG  Tue Feb  7 16:00:32 2012
Return-Path: <owner-freebsd-arm@FreeBSD.ORG>
Delivered-To: freebsd-arm@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 8F7091065679
	for <freebsd-arm@hub.freebsd.org>; Tue,  7 Feb 2012 16:00:32 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id 7DD438FC18
	for <freebsd-arm@hub.freebsd.org>; Tue,  7 Feb 2012 16:00:32 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q17G0WwN052102
	for <freebsd-arm@freefall.freebsd.org>; Tue, 7 Feb 2012 16:00:32 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q17G0WnH052101;
	Tue, 7 Feb 2012 16:00:32 GMT (envelope-from gnats)
Date: Tue, 7 Feb 2012 16:00:32 GMT
Message-Id: <201202071600.q17G0WnH052101@freefall.freebsd.org>
To: freebsd-arm@FreeBSD.org
From: dfilter@FreeBSD.ORG (dfilter service)
Cc: 
Subject: Re: arm/161492: commit references a PR
X-BeenThere: freebsd-arm@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: dfilter service <dfilter@FreeBSD.ORG>
List-Id: Porting FreeBSD to the StrongARM Processor <freebsd-arm.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arm>,
	<mailto:freebsd-arm-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-arm>
List-Post: <mailto:freebsd-arm@freebsd.org>
List-Help: <mailto:freebsd-arm-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arm>,
	<mailto:freebsd-arm-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 07 Feb 2012 16:00:32 -0000

The following reply was made to PR arm/161492; it has been noted by GNATS.

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: arm/161492: commit references a PR
Date: Tue,  7 Feb 2012 15:50:49 +0000 (UTC)

 Author: cognet
 Date: Tue Feb  7 15:50:14 2012
 New Revision: 231131
 URL: http://svn.freebsd.org/changeset/base/231131
 
 Log:
   MFC r226441 and r226443
   r226441:
   Explicitely set ARM_RAS_START and ARM_RAS_END once the cacheline or the
   page has been allocated, or we could end up using random values, and bad things
    could happen.
   
    PR:		arm/161492
    Submitted by:	Ian Lepore <freebsd AT damnhippie dot dyndns DOT org>
   
   r226443:
   Fix 2 bugs :
   
   - A race condition could happen if two threads were using RAS at the same time
     as the code didn't reset RAS_END, the RAS code could believe we were not in
     a RAS, when we were in fact.
   - Using signed value logic to compare addresses wasn't such a good idea.
     Many thanks to Ian to investigate on these issues.
   
     Pointy hat to: 	cognet
     PR:		arm/161498
     Submitted by:	Ian Lepore <freebsd At damnhippie DOT dyndns dot org
 
 Modified:
   stable/8/sys/arm/arm/machdep.c
   stable/8/sys/arm/include/asmacros.h
   stable/8/sys/arm/include/sysarch.h
 
 Modified: stable/8/sys/arm/arm/machdep.c
 ==============================================================================
 --- stable/8/sys/arm/arm/machdep.c	Tue Feb  7 14:50:33 2012	(r231130)
 +++ stable/8/sys/arm/arm/machdep.c	Tue Feb  7 15:50:14 2012	(r231131)
 @@ -312,6 +312,8 @@ cpu_startup(void *dummy)
  	m = vm_page_alloc(NULL, 0, VM_ALLOC_NOOBJ | VM_ALLOC_ZERO);
  	pmap_kenter_user(ARM_TP_ADDRESS, VM_PAGE_TO_PHYS(m));
  #endif
 +	*(uint32_t *)ARM_RAS_START = 0;
 +	*(uint32_t *)ARM_RAS_END = 0xffffffff;
  }
  
  SYSINIT(cpu, SI_SUB_CPU, SI_ORDER_FIRST, cpu_startup, NULL);
 
 Modified: stable/8/sys/arm/include/asmacros.h
 ==============================================================================
 --- stable/8/sys/arm/include/asmacros.h	Tue Feb  7 14:50:33 2012	(r231130)
 +++ stable/8/sys/arm/include/asmacros.h	Tue Feb  7 15:50:14 2012	(r231131)
 @@ -71,9 +71,8 @@
  	ldr	r0, =ARM_RAS_START;					   \
  	mov	r1, #0;							   \
  	str	r1, [r0];						   \
 -	ldr	r0, =ARM_RAS_END;					   \
  	mov	r1, #0xffffffff;					   \
 -	str	r1, [r0];
 +	str	r1, [r0, #4];
  
  /*
   * PULLFRAME - macro to pull a trap frame from the stack in the current mode
 @@ -120,20 +119,19 @@
  	stmia	r0, {r13-r14}^;		/* Push the user mode registers */ \
          mov     r0, r0;                 /* NOP for previous instruction */ \
  	ldr	r5, =ARM_RAS_START;	/* Check if there's any RAS */	   \
 -	ldr	r3, [r5];						   \
 -	cmp	r3, #0;			/* Is the update needed ? */	   \
 -	ldrgt	lr, [r0, #16];						   \
 -	ldrgt	r1, =ARM_RAS_END;					   \
 -	ldrgt	r4, [r1];		/* Get the end of the RAS */	   \
 -	movgt	r2, #0;			/* Reset the magic addresses */	   \
 -	strgt	r2, [r5];						   \
 -	movgt	r2, #0xffffffff;					   \
 -	strgt	r2, [r1];						   \
 -	cmpgt	lr, r3;			/* Were we in the RAS ? */	   \
 -	cmpgt	r4, lr;							   \
 -	strgt	r3, [r0, #16];		/* Yes, update the pc */	   \
 -	mrs	r0, spsr_all;		/* Put the SPSR on the stack */	   \
 -	str	r0, [sp, #-4]!
 +	ldr     r4, [r5, #4];           /* reset it to point at the     */ \
 +	cmp     r4, #0xffffffff;        /* end of memory if necessary;  */ \
 +	movne   r1, #0xffffffff;        /* leave value in r4 for later  */ \
 +	strne   r1, [r5, #4];           /* comparision against PC.      */ \
 +	ldr     r3, [r5];               /* Retrieve global RAS_START    */ \
 +	cmp     r3, #0;                 /* and reset it if non-zero.    */ \
 +	movne   r1, #0;                 /* If non-zero RAS_START and    */ \
 +	strne   r1, [r5];               /* PC was lower than RAS_END,   */ \
 +	ldrne   r1, [r0, #16];          /* adjust the saved PC so that  */ \
 +	cmpne   r4, r1;                 /* execution later resumes at   */ \
 +	strhi   r3, [r0, #16];          /* the RAS_START location.      */ \
 +	mrs     r0, spsr_all;                                              \
 +	str     r0, [sp, #-4]!
  
  /*
   * PULLFRAMEFROMSVCANDEXIT - macro to pull a trap frame from the stack
 
 Modified: stable/8/sys/arm/include/sysarch.h
 ==============================================================================
 --- stable/8/sys/arm/include/sysarch.h	Tue Feb  7 14:50:33 2012	(r231130)
 +++ stable/8/sys/arm/include/sysarch.h	Tue Feb  7 15:50:14 2012	(r231131)
 @@ -42,9 +42,13 @@
   * The ARM_TP_ADDRESS points to a special purpose page, which is used as local
   * store for the ARM per-thread data and Restartable Atomic Sequences support.
   * Put it just above the "high" vectors' page.
 - * the cpu_switch() code assumes ARM_RAS_START is ARM_TP_ADDRESS + 4, and
 + * The cpu_switch() code assumes ARM_RAS_START is ARM_TP_ADDRESS + 4, and
   * ARM_RAS_END is ARM_TP_ADDRESS + 8, so if that ever changes, be sure to
   * update the cpu_switch() (and cpu_throw()) code as well.
 + * In addition, code in arm/include/atomic.h and arm/include/asmacros.h
 + * assumes that ARM_RAS_END is at ARM_RAS_START+4, so be sure to update those
 + * if ARM_RAS_END moves in relation to ARM_RAS_START (look for occurrances
 + * of ldr/str rm,[rn, #4]).
   */
  #define ARM_TP_ADDRESS		(ARM_VECTORS_HIGH + 0x1000)
  #define ARM_RAS_START		(ARM_TP_ADDRESS + 4)
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"