From owner-freebsd-mobile Sat Jul 28 17:22:18 2001 Delivered-To: freebsd-mobile@freebsd.org Received: from quack.kfu.com (quack.kfu.com [205.178.90.194]) by hub.freebsd.org (Postfix) with ESMTP id 6B88C37B405 for ; Sat, 28 Jul 2001 17:22:16 -0700 (PDT) (envelope-from nsayer@quack.kfu.com) Received: from morpheus.kfu.com (morpheus.kfu.com [3ffe:1200:301b:1:2d0:b7ff:fe3f:bdd0]) by quack.kfu.com (8.11.3/8.11.3) with ESMTP id f6T0MAl36145 (using TLSv1/SSLv3 with cipher EDH-RSA-DES-CBC3-SHA (168 bits) verified OK); Sat, 28 Jul 2001 17:22:16 -0700 (PDT) (envelope-from nsayer@quack.kfu.com) Received: from quack.kfu.com (nospam@localhost [127.0.0.1]) by morpheus.kfu.com (8.11.4/8.11.4) with ESMTP id f6T0MA768860; Sat, 28 Jul 2001 17:22:10 -0700 (PDT) (envelope-from nsayer@quack.kfu.com) Message-ID: <3B635732.6030409@quack.kfu.com> Date: Sat, 28 Jul 2001 17:22:10 -0700 From: Nick Sayer User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:0.9.2) Gecko/20010701 X-Accept-Language: en, en-US, en-GB MIME-Version: 1.0 To: Nick Sayer Cc: SXren Schmidt , Richard Johnson , Robert Sexton , freebsd-mobile@FreeBSD.ORG Subject: Re: ATA idle spindown patch. References: <200107280841.f6S8fvR80063@freebsd.dk> <3B6354F9.2070801@quack.kfu.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Sender: owner-freebsd-mobile@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org Nick Sayer wrote: > > I tried to put it in ad_reinit(), but that seems to be causing panics at > resume. The theory was that ad_reinit() seems to be called at resume time. I spoke too soon. I just had to use ATA_WAIT_READY instead of ATA_WAIT_INTR. So I have the same patch as the one that was posted, but I duplicated the 'if ( ata_suspend > 0 )' block at the end if ad_reinit() with ATA_WAIT_READY instead of ATA_WAIT_INTR. With that, spindown survives suspend/resume (well, on resume the drive spins up, obviously, but then after the wait time it spins back down). To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-mobile" in the body of the message