From owner-svn-src-all@freebsd.org Sun Jun 17 02:43:42 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id BA4E8100973A; Sun, 17 Jun 2018 02:43:42 +0000 (UTC) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: from pdx.rh.CN85.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 34A287AD47; Sun, 17 Jun 2018 02:43:42 +0000 (UTC) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: from pdx.rh.CN85.dnsmgr.net (localhost [127.0.0.1]) by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3) with ESMTP id w5H2hb6i058198; Sat, 16 Jun 2018 19:43:37 -0700 (PDT) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: (from freebsd@localhost) by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3/Submit) id w5H2haP5058197; Sat, 16 Jun 2018 19:43:36 -0700 (PDT) (envelope-from freebsd) From: "Rodney W. Grimes" Message-Id: <201806170243.w5H2haP5058197@pdx.rh.CN85.dnsmgr.net> Subject: Re: svn commit: r335270 - head/lib/liby In-Reply-To: To: Eitan Adler Date: Sat, 16 Jun 2018 19:43:36 -0700 (PDT) CC: "Rodney W. Grimes" , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Reply-To: rgrimes@freebsd.org X-Mailer: ELM [version 2.4ME+ PL121h (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 17 Jun 2018 02:43:43 -0000 > On 16 June 2018 at 18:10, Rodney W. Grimes > wrote: > > [ Charset UTF-8 unsupported, converting... ] > >> Author: eadler > >> Date: Sat Jun 16 23:50:34 2018 > >> New Revision: 335270 > >> URL: https://svnweb.freebsd.org/changeset/base/335270 > >> > >> Log: > >> liby: build with WARNS=6 > >> > >> Tested with amd64, arm64, i386, mips > >> > >> Added: > >> head/lib/liby/yyerror.h (contents, props changed) > >> Modified: > >> head/lib/liby/Makefile > >> head/lib/liby/main.c > >> head/lib/liby/yyerror.c > >> > >> Modified: head/lib/liby/Makefile > >> ============================================================================== > >> --- head/lib/liby/Makefile Sat Jun 16 23:49:22 2018 (r335269) > >> +++ head/lib/liby/Makefile Sat Jun 16 23:50:34 2018 (r335270) > >> @@ -5,6 +5,4 @@ LIB= y > >> SRCS= main.c yyerror.c > >> NO_PIC= > >> > >> -WARNS?= 1 > >> - > >> .include > >> > >> Modified: head/lib/liby/main.c > >> ============================================================================== > >> --- head/lib/liby/main.c Sat Jun 16 23:49:22 2018 (r335269) > >> +++ head/lib/liby/main.c Sat Jun 16 23:50:34 2018 (r335270) > >> @@ -32,16 +32,17 @@ > >> #include > >> __FBSDID("$FreeBSD$"); > >> > >> -#ifndef lint > >> +#if defined(LIBC_SCCS) && !defined(lint) > >> static char sccsid[] = "@(#)main.c 8.1 (Berkeley) 6/4/93"; > >> -#endif /* not lint */ > >> +#endif /* LIBC_SCCS and not lint */ > >> > >> #include > >> > >> -int yyparse(void); > >> +#include "yyerror.h" > >> > >> int > >> main(void) > >> { > >> + > >> exit(yyparse()); > >> } > >> > >> Modified: head/lib/liby/yyerror.c > >> ============================================================================== > >> --- head/lib/liby/yyerror.c Sat Jun 16 23:49:22 2018 (r335269) > >> +++ head/lib/liby/yyerror.c Sat Jun 16 23:50:34 2018 (r335270) > >> @@ -32,16 +32,18 @@ > >> #include > >> __FBSDID("$FreeBSD$"); > >> > >> -#ifndef lint > >> +#if defined(LIBC_SCCS) && !defined(lint) > >> static char sccsid[] = "@(#)yyerror.c 8.1 (Berkeley) 6/4/93"; > >> -#endif /* not lint */ > >> +#endif /* LIBC_SCCS and not lint */ > >> > >> #include > >> > >> +#include "yyerror.h" > >> + > >> int > >> -yyerror(msg) > >> -char *msg; > >> +yyerror(const char *msg) > >> { > >> - (void)fprintf(stderr, "%s\n", msg); > >> + > >> + fprintf(stderr, "%s\n", msg); > >> return(0); > >> } > >> > >> Added: head/lib/liby/yyerror.h > >> ============================================================================== > >> --- /dev/null 00:00:00 1970 (empty, because file is newly added) > >> +++ head/lib/liby/yyerror.h Sat Jun 16 23:50:34 2018 (r335270) > >> @@ -0,0 +1,36 @@ > > > > Where did this file come from???? > > I added a header file instead of keeping the prototypes in the .c > files. Is something wrong with that? If you extracted part of a c file and placed it in a .h file, you should add a * from: pathname comment to this yyerror.h What flagged me was we shouldnt just have spontanious files arriving from 1990/1993 UCB. Thanks, Rod @@ -0,0 +1,36 @@ +/*- + * SPDX-License-Identifier: BSD-3-Clause + * + * Copyright (c) 1990, 1993 + * The Regents of the University of California. All rights reserved. + * + * Redistribution and use in source and binary forms, with or without + * modification, are permitted provided that the following conditions + * are met: -- Rod Grimes rgrimes@freebsd.org