Date: Sun, 12 Jun 2005 20:28:44 -0400 (EDT) From: Jeff Roberson <jroberson@chesapeake.net> To: Marcel Moolenaar <marcel@xcllnt.net> Cc: cvs-src@FreeBSD.org, Jeff Roberson <jeff@FreeBSD.org>, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/sys bio.h Message-ID: <20050612202712.U16943@mail.chesapeake.net> In-Reply-To: <cdae9246c661a61c3f81ecd36481ff27@xcllnt.net> References: <200506122233.j5CMX60W020136@repoman.freebsd.org> <cdae9246c661a61c3f81ecd36481ff27@xcllnt.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, 12 Jun 2005, Marcel Moolenaar wrote: > > On Jun 12, 2005, at 3:33 PM, Jeff Roberson wrote: > > > jeff 2005-06-12 22:33:06 UTC > > > > FreeBSD src repository > > > > Modified files: > > sys/sys bio.h > > Log: > > - switch_point is now unused. This doesn't break module binary > > compatability > > since the structure is shrinking, not growing. > > Not true. An array of bio_queue_head will be broken by this change. > Other breakages may be caused by having the field remain uninitialized > or clobbered from the perspective of a module. Passing by value is > also broken. Good point, although I don't think anyone makes arrays of bioq heads or passes by value. Nor did anyone access switch_point directly. So I guess modules in tree should be ok, but other modules may be broken. It is -CURRENT though. I think breaking ABIs is a matter of course. > > If ABI breakage is a concern, this change better be reverted. > > -- > Marcel Moolenaar USPA: A-39004 marcel@xcllnt.net >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20050612202712.U16943>