From owner-cvs-all@FreeBSD.ORG Mon Jun 13 00:28:46 2005 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id CE7B616A41C; Mon, 13 Jun 2005 00:28:46 +0000 (GMT) (envelope-from jroberson@chesapeake.net) Received: from mail.chesapeake.net (chesapeake.net [208.142.252.6]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7765A43D1F; Mon, 13 Jun 2005 00:28:46 +0000 (GMT) (envelope-from jroberson@chesapeake.net) Received: from mail.chesapeake.net (localhost [127.0.0.1]) by mail.chesapeake.net (8.12.10/8.12.10) with ESMTP id j5D0Sjk9054126; Sun, 12 Jun 2005 20:28:45 -0400 (EDT) (envelope-from jroberson@chesapeake.net) Received: from localhost (jroberson@localhost) by mail.chesapeake.net (8.12.10/8.12.10/Submit) with ESMTP id j5D0Sjtb054123; Sun, 12 Jun 2005 20:28:45 -0400 (EDT) (envelope-from jroberson@chesapeake.net) X-Authentication-Warning: mail.chesapeake.net: jroberson owned process doing -bs Date: Sun, 12 Jun 2005 20:28:44 -0400 (EDT) From: Jeff Roberson To: Marcel Moolenaar In-Reply-To: Message-ID: <20050612202712.U16943@mail.chesapeake.net> References: <200506122233.j5CMX60W020136@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Cc: cvs-src@FreeBSD.org, Jeff Roberson , src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/sys bio.h X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Jun 2005 00:28:47 -0000 On Sun, 12 Jun 2005, Marcel Moolenaar wrote: > > On Jun 12, 2005, at 3:33 PM, Jeff Roberson wrote: > > > jeff 2005-06-12 22:33:06 UTC > > > > FreeBSD src repository > > > > Modified files: > > sys/sys bio.h > > Log: > > - switch_point is now unused. This doesn't break module binary > > compatability > > since the structure is shrinking, not growing. > > Not true. An array of bio_queue_head will be broken by this change. > Other breakages may be caused by having the field remain uninitialized > or clobbered from the perspective of a module. Passing by value is > also broken. Good point, although I don't think anyone makes arrays of bioq heads or passes by value. Nor did anyone access switch_point directly. So I guess modules in tree should be ok, but other modules may be broken. It is -CURRENT though. I think breaking ABIs is a matter of course. > > If ABI breakage is a concern, this change better be reverted. > > -- > Marcel Moolenaar USPA: A-39004 marcel@xcllnt.net >