From owner-freebsd-net@FreeBSD.ORG Fri Apr 18 20:17:47 2008 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id BCEFB1065670 for ; Fri, 18 Apr 2008 20:17:47 +0000 (UTC) (envelope-from kip.macy@gmail.com) Received: from wx-out-0506.google.com (wx-out-0506.google.com [66.249.82.238]) by mx1.freebsd.org (Postfix) with ESMTP id 75AAA8FC12 for ; Fri, 18 Apr 2008 20:17:47 +0000 (UTC) (envelope-from kip.macy@gmail.com) Received: by wx-out-0506.google.com with SMTP id i29so640308wxd.7 for ; Fri, 18 Apr 2008 13:17:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; bh=1JFcuLPPbKsrSusRgjraXsoLpC3ZYBFkdcGJghrK9cA=; b=EqjkocMPEueMKY3j++VIb9zHyxjlIPcKPEjnmCqqSmDTVOfe9LYTq8Za9mIYf+C464FGwb1AeWd0/TjPJzTj47tcEbohtOn5tMYijsBP1TOAUNS/8OHrzp9j9gU//+MQXck+hxy8gFrlDK7RDQpPcnD+plZ/DKgeD22qRj+erzM= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=sFqjvuaye6j8hXZUuPBBfXdZKFaCxOOu2x9qrKnUx7BcaJOmidLI/yHb9ViHD8A87YW6ieMye+xGNict4hMVjvxvlTfB5vQ3uNSCjrbYuiQAJin4HU2pTfyr/Lh2amNeXivGbErC00apQLCtgGoheKtWZn/K0cm4jwcZcogJKMs= Received: by 10.114.161.11 with SMTP id j11mr3115953wae.221.1208549862064; Fri, 18 Apr 2008 13:17:42 -0700 (PDT) Received: by 10.114.255.16 with HTTP; Fri, 18 Apr 2008 13:17:41 -0700 (PDT) Message-ID: Date: Fri, 18 Apr 2008 13:17:41 -0700 From: "Kip Macy" To: gnn@freebsd.org In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: Cc: "freebsd-net@freebsd.org" Subject: Re: MFC of TOE support to RELENG_7 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Apr 2008 20:17:47 -0000 On Thu, Apr 17, 2008 at 11:32 PM, wrote: > At Thu, 17 Apr 2008 21:00:04 -0700, > > Kip Macy wrote: > > > > I would like to MFC TOE and RDMA support in the last week of May / > > first week of June. My primary objective is that it be present in 7.1. > > The re team has not yet decided when the freeze date for 7.1 will be, > > so I may end up asking to do it earlier. > > > > The reason I'm bringing it up roughly 6 weeks in advance is that there > > is a certain amount of debate with regards to the ABI guarantees that > > FreeBSD network developers are willing to commit to for the remaining > > life of the RELENG_7 branch. > > > > I've made the following two simplifying assumptions: > > - struct tcpcb and struct sockbuf are append only - i.e. if members > > are added, they will be added to the end > > - lock ordering will not change, e.g. the inpcb lock will always be > > acquired before the sockbuf lock > > > > Is there any reason to believe that these simplifying assumptions are > > not acceptable? If so, why? > > > > > > I've added the following sets of accessor functions: > > - lock acquire/release for socket, sockbuf, inpcb > > - higher level functions for tcp shutdown and syncache to abstract > > away the tcbinfo lock > > - accessor functions for all the accessed fields in socket and > > inpcb so that none of the members are referenced as offsets from the > > base of the structure > > I apologize for not yet reviewing all the code. I take that last bit > to mean the drivers can reach up into sockets given those functions? > I gather this is due to the work necessary to implement RDMA over TCP? > > > > The current state of the code can be seen at: > > http://157.22.130.171/svn/branches/projects/iwarp/sys/ > > Is there a simple way to get just that directory without doing a svn > on your whole repo? And if not, what's the easiest way to just grab > that stuff? You can check out any individual subdirectory, eg. svk co http://157.22.130.171/svn/branches/projects/iwarp/sys/contrib/rdma/