Date: Fri, 3 Mar 2017 16:34:22 +0200 From: Andriy Gapon <avg@FreeBSD.org> To: Hans Petter Selasky <hps@selasky.org>, src-committers@FreeBSD.org, svn-src-all@FreeBSD.org, svn-src-stable@FreeBSD.org, svn-src-stable-10@FreeBSD.org Subject: Re: svn commit: r314594 - stable/10/sys/modules/mlx5 Message-ID: <915cdd8f-0f12-0bb1-9c8d-e4813e275141@FreeBSD.org> In-Reply-To: <bdb13a79-d204-7e15-65b2-6e2f45dd4560@selasky.org> References: <201703031206.v23C6XTF055972@repo.freebsd.org> <bdb13a79-d204-7e15-65b2-6e2f45dd4560@selasky.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 03/03/2017 16:18, Hans Petter Selasky wrote: > On 03/03/17 13:06, Andriy Gapon wrote: >> Author: avg >> Date: Fri Mar 3 12:06:33 2017 >> New Revision: 314594 >> URL: https://svnweb.freebsd.org/changeset/base/314594 >> >> Log: >> mlx5 module: remove include path that doesn't exist in this branch >> >> This is a direct commit. >> It allows the module to be compiled with the base gcc. >> >> Modified: >> stable/10/sys/modules/mlx5/Makefile >> >> Modified: stable/10/sys/modules/mlx5/Makefile >> ============================================================================== >> --- stable/10/sys/modules/mlx5/Makefile Fri Mar 3 12:03:50 2017 (r314593) >> +++ stable/10/sys/modules/mlx5/Makefile Fri Mar 3 12:06:33 2017 (r314594) >> @@ -30,7 +30,6 @@ device_if.h bus_if.h vnode_if.h pci_if.h >> SRCS+= linux_compat.c linux_radix.c linux_idr.c >> >> CFLAGS+= -I${.CURDIR}/../../ofed/include >> -CFLAGS+= -I${.CURDIR}/../../compat/linuxkpi/common/include >> >> .include <bsd.kmod.mk> >> > > Hi, > > Which version of GCC is this? gcc version 4.2.1 20070831 patched [FreeBSD] That is, the compiler that you get when clang is disabled. > Do you want me to check for this kind of errors before committing or are you > fine cleaning up every now and then? Currently the mlx4/mlx5 code is only tested > with the in-base compiler. Checking with a non-default compiler is probably too much a burden for anyone who doesn't use it regularly. -- Andriy Gapon
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?915cdd8f-0f12-0bb1-9c8d-e4813e275141>