Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 05 Oct 2010 19:35:03 +0400
From:      Anonymous <swell.k@gmail.com>
To:        Dirk Meyer <dinoex@FreeBSD.org>
Cc:        cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, bug-followup@FreeBSD.org, ports-committers@FreeBSD.org
Subject:   Re: ports/150982: [patch] net-p2p/ed2k: typo and wrong amule pkgname in CONFLICTS
Message-ID:  <8662xgejq0.fsf@gmail.com>
In-Reply-To: <201010050846.o958keq8000302@repoman.freebsd.org> (Dirk Meyer's message of "Tue, 5 Oct 2010 08:46:40 %2B0000 (UTC)")
References:  <201010050846.o958keq8000302@repoman.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
(subject modified for gnats)

Dirk Meyer <dinoex@FreeBSD.org> writes:

> regression found:
> CFLAGS+= was not passed if you have CFLAGS in /etc/make.conf

Did you by chance use CFLAGS= instead of CFLAGS+= in make.conf?

> dinoex      2010-10-05 08:46:40 UTC
>
>   FreeBSD ports repository
>
>   Modified files:
>     net-p2p/ed2k         Makefile
>   Log:
>   - fix typo: CONFILTCS vs. CONFLICTS

Typo is still there.

>   - use current lowercase amule pkgname in CONFLICTS
>   - don't abuse LDLIBS for CPPFLAGS
>   - use NO_WRKSUBDIR
>   - install verbosely like most ports do
>   PR:             150982
>   Submitted by:   swell.k

>   - Fix PKGNAME logic

It breaks CONFLICTS in amule ports even more.
And remove PKGNAMESUFFIX2 if it's not defined anywhere.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?8662xgejq0.fsf>