From owner-freebsd-net@FreeBSD.ORG  Sun Mar  1 21:45:58 2009
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
Delivered-To: net@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 29926106566B
	for <net@FreeBSD.org>; Sun,  1 Mar 2009 21:45:58 +0000 (UTC)
	(envelope-from julian@elischer.org)
Received: from outT.internet-mail-service.net (outt.internet-mail-service.net
	[216.240.47.243])
	by mx1.freebsd.org (Postfix) with ESMTP id BE3258FC14
	for <net@FreeBSD.org>; Sun,  1 Mar 2009 21:45:56 +0000 (UTC)
	(envelope-from julian@elischer.org)
Received: from idiom.com (mx0.idiom.com [216.240.32.160])
	by out.internet-mail-service.net (Postfix) with ESMTP id C1BF8B4E5;
	Sun,  1 Mar 2009 13:34:07 -0800 (PST)
X-Client-Authorized: MaGic Cook1e
X-Client-Authorized: MaGic Cook1e
Received: from julian-mac.elischer.org (home.elischer.org [216.240.48.38])
	by idiom.com (Postfix) with ESMTP id 8EDBD2D600D;
	Sun,  1 Mar 2009 13:34:07 -0800 (PST)
Message-ID: <49AAFF4F.6010400@elischer.org>
Date: Sun, 01 Mar 2009 13:34:07 -0800
From: Julian Elischer <julian@elischer.org>
User-Agent: Thunderbird 2.0.0.19 (Macintosh/20081209)
MIME-Version: 1.0
To: Ed Schouten <ed@80386.nl>
References: <20090301161827.GR19161@hoeg.nl>
In-Reply-To: <20090301161827.GR19161@hoeg.nl>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: net@FreeBSD.org
Subject: Re: Making Netgraph compile with LLVM
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 01 Mar 2009 21:45:58 -0000

Ed Schouten wrote:
> Hello all,
> 
> It turns out Netgraph uses a language construct that is only allowed
> with GCC, but not with LLVM. According to the specs, LLVM's behaviour is
> correct. It is not allowed to do this:
> 
> 	struct a {
> 		struct {
> 			int i;
> 			char j[];
> 		} b;
> 		char k[20];
> 	};
> 
> error: variable sized type 'b' must be at end of struct or class

not sure wher eyou are seeing this.

the examples you fix don't seem to be nested structs..  what is the 
outer struct?

> 
> Diane Bruce and I thought this patch should solve this issue:
> 
> 	http://80386.nl/pub/ng.diff
> 
> Yes, I know, the solution isn't really elegant, but I think this is the
> only way to do this safely. Diane and I also compared the output of
> objdump and they seem to be equivalent, except for some reordering.
> 
> Objections before I commit this to SVN?
>