From owner-freebsd-git@freebsd.org Wed Mar 1 14:48:03 2017 Return-Path: Delivered-To: freebsd-git@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7E9D8CF0709 for ; Wed, 1 Mar 2017 14:48:03 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mailman.ysv.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 5D40686F for ; Wed, 1 Mar 2017 14:48:03 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mailman.ysv.freebsd.org (Postfix) id 5CA4FCF0708; Wed, 1 Mar 2017 14:48:03 +0000 (UTC) Delivered-To: git@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 5C535CF0707 for ; Wed, 1 Mar 2017 14:48:03 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-io0-x22c.google.com (mail-io0-x22c.google.com [IPv6:2607:f8b0:4001:c06::22c]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 2EC4786D for ; Wed, 1 Mar 2017 14:48:03 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-io0-x22c.google.com with SMTP id l7so32272354ioe.3 for ; Wed, 01 Mar 2017 06:48:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc:content-transfer-encoding; bh=PllTfJ7qGu/aZJ3oDfrOBU3bFJjg+QKjmZ4AktPptAE=; b=LRBZbzhv20v4HWivHUItHV1s7nVgJbEDR7uVhgrOIOazkns8KxoVBiGciJqmDJOuUV 16dOk0JwKOqiwD4yBTGZanUoK2yDi1kK1jY0J67bqlemdenJgYx8d56OFXyl3q0LeANG 5jm5TKt/hWv5H2fviNlAG5db1ZTKcqqjao37B/FMOM0vPdw4oAUSt+AUYGQr46IaHD4w p2GZ70216ycppJMv5g17CnHxxxKYBk8cg57rtfOk4AjImTm3dAez7zqX/0UBxjVM/aNJ tMpqdG4NDoDrjJ4h06fxEzQq56OIwAFxJqRayEvF5IecIMet7X4e6WeHkryqFBEVXGPc ZjSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc:content-transfer-encoding; bh=PllTfJ7qGu/aZJ3oDfrOBU3bFJjg+QKjmZ4AktPptAE=; b=U6CX36s3VW0+g1GB1PnpizGMUGJ7nFvB8fzHUBnejvWMNrrXUZ9rwKtgPeYm7km2UI 6ezoWniuo65TP1bBWn/wDILRoa0OjNjRRI0PMWekJ4j6eH11bqhnqGzQndivCqX3xm/z 4/L9DWwQHEAQFjonL5NK5hi4R76EHwJ1BxG7n6B+N5DIN46H10GUf/C914tZCJJrLJGt uGjqJ+ZYiIoxI7UySE4B0HRs67J8t8AuCOrBH4p2Kji9ZiJmFQtOKRFK8LtctW8lJyah hmrsv+c+wzJcSED7bNNAyfcsDBcmfEoqw5fWPp8l3R8p1lqaC8aEJ3dNdcse75l7s3dv WreQ== X-Gm-Message-State: AMke39mMWyenOqeH0HD2n8WGaEQ54AraSWjfnr/l4JWm2rFOHbUqtGfvMkOpbl0d0aqTJF8IgWeaYiX5FaWmpw== X-Received: by 10.107.134.94 with SMTP id i91mr8679018iod.0.1488379682306; Wed, 01 Mar 2017 06:48:02 -0800 (PST) MIME-Version: 1.0 Sender: wlosh@bsdimp.com Received: by 10.79.134.129 with HTTP; Wed, 1 Mar 2017 06:48:01 -0800 (PST) X-Originating-IP: [50.253.99.174] In-Reply-To: References: From: Warner Losh Date: Wed, 1 Mar 2017 07:48:01 -0700 X-Google-Sender-Auth: W_acLikViitTUuMvNR4ceqqDxcA Message-ID: Subject: Re: pull requests To: =?UTF-8?Q?Bart=C5=82omiej_Rutkowski?= Cc: git@freebsd.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: freebsd-git@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Discussion of git use in the FreeBSD project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Mar 2017 14:48:03 -0000 On Wed, Mar 1, 2017 at 2:36 AM, Bart=C5=82omiej Rutkowski wrote: > > > On Wed, Mar 1, 2017 at 12:16 AM, Warner Losh wrote: >> >> So, policy on github pull requests. >> >> Do we have one? >> >> If not, I'm going to set a sensible one and publish. Or set one and >> get you folks to review. I'd like to see us down to 0 open pull >> requests by the end of March. >> >> Warner > > > What kind of policy, regarding what and 'policing' what and how exactly? = Who > and how will enforce such policy and on whom? In the end, "we can't force > anyone to do anything" so unless we commit to do something on GitHub, I'd > see it as a dead law. This answer wins my "Least helpful answer of the year award." Insert rant h= ere. > Not to mention I've got a feeling this is completely disconnected from th= e > general direction that I think has been 'agreed', that is we'll have a > software solution getting GH PR's into Phabric reviews and GH Issues into > Bugzilla PR's automatically. What then, shouldn't it be more like Phabric > reviews/Bugzilla PR policy instead? It certainly doesn't. It documents what we do with them today. Anyway, I got bored waiting for people to answer, so I did this https://wiki.freebsd.org/GithubPullRequests Which basically says if it is committable, we'll channel it in, otherwise we won't. And we'll close after a month by pushing it off to bugzilla. I'd like useful feedback on that. And if things change, we change the above. It's not like we have to guarantee anything. We just have to document what people can expect. If others make it more automated or better than my efforts, great. We document that when it comes along. Warner