From owner-cvs-all  Tue May  1  7:19:16 2001
Delivered-To: cvs-all@freebsd.org
Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16])
	by hub.freebsd.org (Postfix) with ESMTP
	id 6964B37B422; Tue,  1 May 2001 07:19:05 -0700 (PDT)
	(envelope-from bde@zeta.org.au)
Received: from bde.zeta.org.au (bde.zeta.org.au [203.2.228.102])
	by mailman.zeta.org.au (8.9.3/8.8.7) with ESMTP id AAA07324;
	Wed, 2 May 2001 00:18:40 +1000
Date: Wed, 2 May 2001 00:17:33 +1000 (EST)
From: Bruce Evans <bde@zeta.org.au>
X-Sender: bde@besplex.bde.org
To: Mark Murray <mark@grondar.za>
Cc: Mark Murray <markm@FreeBSD.org>, cvs-committers@FreeBSD.org,
	cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/bin/ps keyword.c print.c ps.c 
In-Reply-To: <200105011229.f41CTAp46288@gratis.grondar.za>
Message-ID: <Pine.BSF.4.21.0105020001340.35275-100000@besplex.bde.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.ORG

On Tue, 1 May 2001, Mark Murray wrote:

> > >   Revision  Changes    Path
> > >   1.31      +2 -1      src/bin/ps/keyword.c
> > >   1.46      +2 -1      src/bin/ps/print.c
> > >   1.38      +2 -1      src/bin/ps/ps.c
> > 
> > This is bogus.  Correct dethreading of kernel headers can't affect userland.
> 
> Easiest solution is to include sys/lockmgr.h in vm/vm_map.h. Other

That's what my version happens to be doing :-).  ISTR adding it there just
for the kernel.

I think little or nothing of <vm/vm_map.h> and nothing of <sys/lockmgr.h>
should escape to userland, but both are currently nescessary (there
is a `struct vm_map' in `struct vmspace' and a `struct lock' in `struct
vm_map'...).  <sys/vm_map.h> escapes via a bogus include in <sys/user.h>.
Previously <sys/user.h> bogusly included <sys/lock.h> which bogusly
includes <sys/lockmgr.h>, but <sys/user.h> now includes <sys/_lock.h>
instead.  I think the lockmgr include is least evil in <sys/vm_map.h>
because <sys/user.h> doesn't need it directly.

Bruce


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message