Date: Wed, 2 May 2001 00:17:33 +1000 (EST) From: Bruce Evans <bde@zeta.org.au> To: Mark Murray <mark@grondar.za> Cc: Mark Murray <markm@FreeBSD.org>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/bin/ps keyword.c print.c ps.c Message-ID: <Pine.BSF.4.21.0105020001340.35275-100000@besplex.bde.org> In-Reply-To: <200105011229.f41CTAp46288@gratis.grondar.za>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, 1 May 2001, Mark Murray wrote: > > > Revision Changes Path > > > 1.31 +2 -1 src/bin/ps/keyword.c > > > 1.46 +2 -1 src/bin/ps/print.c > > > 1.38 +2 -1 src/bin/ps/ps.c > > > > This is bogus. Correct dethreading of kernel headers can't affect userland. > > Easiest solution is to include sys/lockmgr.h in vm/vm_map.h. Other That's what my version happens to be doing :-). ISTR adding it there just for the kernel. I think little or nothing of <vm/vm_map.h> and nothing of <sys/lockmgr.h> should escape to userland, but both are currently nescessary (there is a `struct vm_map' in `struct vmspace' and a `struct lock' in `struct vm_map'...). <sys/vm_map.h> escapes via a bogus include in <sys/user.h>. Previously <sys/user.h> bogusly included <sys/lock.h> which bogusly includes <sys/lockmgr.h>, but <sys/user.h> now includes <sys/_lock.h> instead. I think the lockmgr include is least evil in <sys/vm_map.h> because <sys/user.h> doesn't need it directly. Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.21.0105020001340.35275-100000>