From owner-freebsd-stable Mon Feb 5 14: 4:54 2001 Delivered-To: freebsd-stable@freebsd.org Received: from entropy.mx (CC2-1326.charter-stl.com [24.217.117.56]) by hub.freebsd.org (Postfix) with ESMTP id 575C337B401 for ; Mon, 5 Feb 2001 14:04:31 -0800 (PST) Received: (from ajh3@localhost) by entropy.mx (8.11.2/8.11.1) id f15M4Db01559 for freebsd-stable@freebsd.org; Mon, 5 Feb 2001 16:04:13 -0600 (CST) (envelope-from ajh3) Date: Mon, 5 Feb 2001 16:04:12 -0600 From: Andrew Hesford To: freebsd-stable@freebsd.org Subject: Problems with netgraph in today's 4.2-STABLE Message-ID: <20010205160412.A1535@cec.wustl.edu> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i X-Loop: Andrew Hesford Sender: owner-freebsd-stable@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG I tried building today's -STABLE kernel, and it failed while building modules. There is a parse error in /usr/src/sys/netgear/ng_base.c, on line 602, in the function ng_findname(). The error comes from having too many parentheses in the if condition in the LIST_FOREACH block, as seen below: /* Find node by name */ LIST_FOREACH(node, &nodelist, nodes) { if (((node->name != NULL) && (strcmp(node->name, name) == 0)) && (node->flags & NG_INVALID) == 0)) break; The last closing parenthesis in that block, "&& (node->flags & NG_INVALID) == 0))", should be removed. This will allow compilation without errors. Happy building. -- Andrew Hesford - ajh3@chmod.ath.cx "355/113 -- Not the famous irrational number PI, but an incredible simulation!" To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-stable" in the body of the message