From owner-cvs-all@FreeBSD.ORG Mon Nov 20 04:14:24 2006 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 3D67016A403; Mon, 20 Nov 2006 04:14:24 +0000 (UTC) (envelope-from mohans@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.FreeBSD.org (Postfix) with ESMTP id 50AD343D49; Mon, 20 Nov 2006 04:14:10 +0000 (GMT) (envelope-from mohans@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kAK4ENkq032694; Mon, 20 Nov 2006 04:14:23 GMT (envelope-from mohans@repoman.freebsd.org) Received: (from mohans@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kAK4EN1T032693; Mon, 20 Nov 2006 04:14:23 GMT (envelope-from mohans) Message-Id: <200611200414.kAK4EN1T032693@repoman.freebsd.org> From: Mohan Srinivasan Date: Mon, 20 Nov 2006 04:14:23 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/nfsclient nfs.h nfs_socket.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Nov 2006 04:14:24 -0000 mohans 2006-11-20 04:14:23 UTC FreeBSD src repository Modified files: sys/nfsclient nfs.h nfs_socket.c Log: 1) Fix up locking in nfs_up() and nfs_down. 2) Reduce the acquisitions of the Giant lock in the nfs_socket.c paths significantly. - We don't need to acquire Giant before tsleeping on lbolt anymore, since jhb specialcased lbolt handling in msleep. - nfs_up() needs to acquire Giant only if printing the "server up" message. - nfs_timer() held Giant for the duration of the NFS timer processing, just because the printing of the message in nfs_down() needed it (and we acquire other locks in nfs_timer()). The acquisition of Giant is moved down into nfs_down() now, reducing the time Giant is held in that path. Reported by: Kris Kennaway Revision Changes Path 1.97 +1 -1 src/sys/nfsclient/nfs.h 1.146 +39 -30 src/sys/nfsclient/nfs_socket.c