Skip site navigation (1)Skip section navigation (2) 
Date:      Sat, 19 Jan 2019 20:45:41 +0000 (UTC)
From:      Toomas Soome <tsoome@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r343203 - head/sys/dev/ixgbe
Message-ID:  <201901192045.x0JKjf04077081@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help 
Author: tsoome
Date: Sat Jan 19 20:45:41 2019
New Revision: 343203
URL: https://svnweb.freebsd.org/changeset/base/343203

Log:
  ixgbe: this statement may fall through warnings with gcc
  
  The recent gcc versions (7 and 8 at least) can check for switch case
  statements for fall through (implicit-fallthrough). When fall through
  is intentional, the default method for warning suppression is to place
  comment /* FALLTHROUGH */ exactly before next case statement.
  
  Differential Revision:	https://reviews.freebsd.org/D18577

Modified:
  head/sys/dev/ixgbe/ixgbe_82599.c
  head/sys/dev/ixgbe/ixgbe_common.c

Modified: head/sys/dev/ixgbe/ixgbe_82599.c
==============================================================================
--- head/sys/dev/ixgbe/ixgbe_82599.c	Sat Jan 19 19:04:00 2019	(r343202)
+++ head/sys/dev/ixgbe/ixgbe_82599.c	Sat Jan 19 20:45:41 2019	(r343203)
@@ -1750,7 +1750,7 @@ s32 ixgbe_fdir_set_input_mask_82599(struct ixgbe_hw *h
 	case 0x0000:
 		/* mask VLAN ID */
 		fdirm |= IXGBE_FDIRM_VLANID;
-		/* fall through */
+		/* FALLTHROUGH */
 	case 0x0FFF:
 		/* mask VLAN priority */
 		fdirm |= IXGBE_FDIRM_VLANP;
@@ -2039,7 +2039,7 @@ s32 ixgbe_fdir_add_perfect_filter_82599(struct ixgbe_h
 			DEBUGOUT(" Error on src/dst port\n");
 			return IXGBE_ERR_CONFIG;
 		}
-		/* fall through */
+		/* FALLTHROUGH */
 	case IXGBE_ATR_FLOW_TYPE_TCPV4:
 	case IXGBE_ATR_FLOW_TYPE_TUNNELED_TCPV4:
 	case IXGBE_ATR_FLOW_TYPE_UDPV4:

Modified: head/sys/dev/ixgbe/ixgbe_common.c
==============================================================================
--- head/sys/dev/ixgbe/ixgbe_common.c	Sat Jan 19 19:04:00 2019	(r343202)
+++ head/sys/dev/ixgbe/ixgbe_common.c	Sat Jan 19 20:45:41 2019	(r343203)
@@ -269,7 +269,8 @@ s32 ixgbe_setup_fc_generic(struct ixgbe_hw *hw)
 		if (ret_val != IXGBE_SUCCESS)
 			goto out;
 
-		/* fall through - only backplane uses autoc */
+		/* only backplane uses autoc */
+		/* FALLTHROUGH */
 	case ixgbe_media_type_fiber_fixed:
 	case ixgbe_media_type_fiber_qsfp:
 	case ixgbe_media_type_fiber:
@@ -4756,7 +4757,8 @@ void ixgbe_set_rxpba_generic(struct ixgbe_hw *hw, int 
 		rxpktsize <<= IXGBE_RXPBSIZE_SHIFT;
 		for (; i < (num_pb / 2); i++)
 			IXGBE_WRITE_REG(hw, IXGBE_RXPBSIZE(i), rxpktsize);
-		/* fall through - configure remaining packet buffers */
+		/* configure remaining packet buffers */
+		/* FALLTHROUGH */
 	case PBA_STRATEGY_EQUAL:
 		rxpktsize = (pbsize / (num_pb - i)) << IXGBE_RXPBSIZE_SHIFT;
 		for (; i < num_pb; i++)

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201901192045.x0JKjf04077081>