From owner-freebsd-current@freebsd.org Tue Jun 23 16:04:40 2020 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id A5B663314AC for ; Tue, 23 Jun 2020 16:04:40 +0000 (UTC) (envelope-from freqlabs@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 49rrh8420Rz3Vjt for ; Tue, 23 Jun 2020 16:04:40 +0000 (UTC) (envelope-from freqlabs@FreeBSD.org) Received: from Ryans-MBP.attlocal.net (unknown [IPv6:2600:1700:358a:c660:408c:dcf3:301c:3a64]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) (Authenticated sender: freqlabs/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 6FCBE170C9 for ; Tue, 23 Jun 2020 16:04:40 +0000 (UTC) (envelope-from freqlabs@FreeBSD.org) Subject: Re: openzfs-kmod build error To: freebsd-current@freebsd.org References: <1250230056.4543844.1592922228227.ref@mail.yahoo.com> <1250230056.4543844.1592922228227@mail.yahoo.com> From: Ryan Moeller Message-ID: <260a4489-031a-5b61-d8e6-c0572a2bd597@FreeBSD.org> Date: Tue, 23 Jun 2020 12:04:39 -0400 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:68.0) Gecko/20100101 Thunderbird/68.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Jun 2020 16:04:40 -0000 On 6/23/20 11:12 AM, Rick Macklem wrote: > Kostya Berger wrote: >> CURRENT r362292 >> sysutils/openzfs-kmod build aborts with error:............... >> /usr/ports/sysutils/openzfs-kmod/work/zfs->c0eb5c35e/module/os/freebsd/zfs/zfs_vfsops.c:128:19: error: >> incompatible pointer types initializing 'vfs_checkexp_t *' (aka 'int (*)(struct >> mount *, struct sockaddr *, unsigned long *, struct ucred **, int *, int *)') with >> an expression of type 'int (vfs_t *, struct sockaddr *, int *, struct ucred **, int >> *, int **)' (aka 'int (struct mount *, struct sockaddr *, int *, struct ucred **, >> int *, int **)') [-Werror,-Wincompatible-pointer-types] >> .vfs_checkexp = zfs_checkexp, >> ^~~~~~~~~~~~ >> /usr/ports/sysutils/openzfs-kmod/work/zfs->c0eb5c35e/module/os/freebsd/zfs/zfs_vfsops.c:1911:56: error: >> incompatible pointer types passing 'int *' to parameter of type 'uint64_t *' >> (aka 'unsigned long *') [-Werror,-Wincompatible-pointer-types] >> return (vfs_stdcheckexp(zfsvfs->z_parent->z_vfs, nam, extflagsp, >> ^~~~~~~~~ >> /usr/src/sys/sys/mount.h:980:17: note: passing argument to parameter here >> vfs_checkexp_t vfs_stdcheckexp; >> ^ >> /usr/ports/sysutils/openzfs-kmod/work/zfs->c0eb5c35e/module/os/freebsd/zfs/zfs_vfsops.c:1912:32: error: >> incompatible pointer types passing 'int **' to parameter of type 'int *'; >> dereference with * [-Werror,-Wincompatible-pointer-types] >> credanonp, numsecflavors, secflavors)); >> ^~~~~~~~~~ >> * >> /usr/src/sys/sys/mount.h:980:17: note: passing argument to parameter here >> vfs_checkexp_t vfs_stdcheckexp; >> ^ >> 3 errors generated. >> *** Error code 1 >> >> Stop. > Post r362158, the argument types change. Since they are just passed to > vfs_stdcheckexp(), all that needs to be done is changing the types of > the arguments. > > freqlabs@ volunteered to do this upstream, but I don't know if/when > that gets applied to the port? The port has already been updated, so update the ports tree checkout and you should be good. -Ryan > If you can fix this, simply replace: > zfs_checkexp(vfs_t *vfsp, struct sockaddr *nam, int *extflagsp, > struct ucred **credanonp, int *numsecflavors, int **secflavors) > > with > > zfs_checkexp(vfs_t *vfsp, struct sockaddr *nam, uint64_t *extflagsp, > struct ucred **credanonp, int *numsecflavors, int *secflavors) > > in the two places it exists in zfs_vfsops.c. > > rick > > > > With kindest regards, > Kostya Berger > > _______________________________________________ > freebsd-current@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-current > To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org" > _______________________________________________ > freebsd-current@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-current > To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org"