From owner-freebsd-ports@FreeBSD.ORG  Sat Jan 14 13:27:34 2006
Return-Path: <owner-freebsd-ports@FreeBSD.ORG>
X-Original-To: ports@freebsd.org
Delivered-To: freebsd-ports@FreeBSD.ORG
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 2A8DE16A41F;
	Sat, 14 Jan 2006 13:27:34 +0000 (GMT)
	(envelope-from itetcu@people.tecnik93.com)
Received: from garek.tecnik93.com (garek.tecnik93.com [82.76.1.117])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 8227A43D45;
	Sat, 14 Jan 2006 13:27:33 +0000 (GMT)
	(envelope-from itetcu@people.tecnik93.com)
Received: from garek.tecnik93.com (localhost [127.0.0.1])
	by garek.tecnik93.com (Postfix) with ESMTP id 96802619E;
	Sat, 14 Jan 2006 15:27:26 +0200 (EET)
Received: from it.buh.cameradicommercio.ro (it.buh.cameradicommercio.ro
	[192.168.0.10]) by garek.tecnik93.com (Postfix) with ESMTP;
	Sat, 14 Jan 2006 15:27:26 +0200 (EET)
Received: from it.buh.cameradicommercio.ro (localhost.buh.tecnik93.com
	[127.0.0.1])
	by it.buh.cameradicommercio.ro (Postfix) with ESMTP id D362123;
	Sat, 14 Jan 2006 15:27:25 +0200 (EET)
Date: Sat, 14 Jan 2006 15:27:25 +0200
From: Ion-Mihai Tetcu <itetcu@people.tecnik93.com>
To: Doug Barton <dougb@FreeBSD.org>
Message-ID: <20060114152725.3365c0bc@it.buh.cameradicommercio.ro>
In-Reply-To: <43C8A3BC.1070108@FreeBSD.org>
References: <1137031540.61580@it.buh.tecnik93.com>
	<43C6EAE9.5070901@rogers.com>
	<20060113020125.5c1317a1@it.buh.tecnik93.com>
	<43C8A3BC.1070108@FreeBSD.org>
X-Mailer: Sylpheed-Claws 1.9.100 (GTK+ 2.8.9; i386-portbld-freebsd6.0)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
X-AV-Checked: on buh by ClamAV using ClamSMTP
Cc: ports@freebsd.org, Mike Jakubik <mikej@rogers.com>,
	FreeBSD gnats submit <FreeBSD-gnats-submit@freebsd.org>
Subject: Re: [PATCH] security/courier-authlib-base: update rc.d script to
 REQUIRE mysql_client
X-BeenThere: freebsd-ports@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports>
List-Post: <mailto:freebsd-ports@freebsd.org>
List-Help: <mailto:freebsd-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 14 Jan 2006 13:27:34 -0000

On Fri, 13 Jan 2006 23:09:48 -0800
Doug Barton <dougb@FreeBSD.org> wrote:

> Ion-Mihai Tetcu wrote:
> > On Thu, 12 Jan 2006 18:48:57 -0500
> > Mike Jakubik <mikej@rogers.com> wrote:
> 
> >> I think the real solution would be to generate the required
> >> services dynamically based on what the port is compiled with. This
> >> obviously means some more work, but i think a lot of port
> >> maintainers will have to go through this, to properly utilize
> >> RCng. Examples can be apparently taken from the misc/compat5 port.
> > 
> > Or my mail/dspam-devel.
> 
> You definitely have some cool stuff in there! I would like to mention
> one little nit, that I was actually reminded of myself recently. When
> you do default variable values, it's better to do it like this:
> 
> dspam_enable=${dspam_enable-"NO"}

Yes, I saw the discussion on ports@ and #bsdports. I will update my
ports these days to have this syntax; I would have liked to have it
done by now but $REAL_LIFE got in the way.


-- 
IOnut
Unregistered ;) FreeBSD "user"