From owner-cvs-usrsbin Thu May 11 12:35:04 1995 Return-Path: cvs-usrsbin-owner Received: (from majordom@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id MAA11241 for cvs-usrsbin-outgoing; Thu, 11 May 1995 12:35:04 -0700 Received: from time.cdrom.com (time.cdrom.com [192.216.223.46]) by freefall.cdrom.com (8.6.10/8.6.6) with ESMTP id MAA11235 ; Thu, 11 May 1995 12:35:02 -0700 Received: from godzilla.zeta.org.au (godzilla.zeta.org.au [203.2.228.34]) by time.cdrom.com (8.6.11/8.6.9) with ESMTP id MAA02386; Thu, 11 May 1995 12:34:30 -0700 Received: (from bde@localhost) by godzilla.zeta.org.au (8.6.9/8.6.9) id FAA28582; Fri, 12 May 1995 05:33:34 +1000 Date: Fri, 12 May 1995 05:33:34 +1000 From: Bruce Evans Message-Id: <199505111933.FAA28582@godzilla.zeta.org.au> To: bde@zeta.org.au, davidg@Root.COM Subject: Re: cvs commit: src/usr.sbin/config mkioconf.c Cc: CVS-commiters@time.cdrom.com, cvs-usrsbin@time.cdrom.com, jkh@time.cdrom.com Sender: cvs-usrsbin-owner@freebsd.org Precedence: bulk >>id_conflicts was in the right place before. id_enabled is in the wrong >>place (at the end). None of the internal (initially 0) fields should be >>printed, but putting id_enabled at the end messed this up. Internal >>pointer fields such as id_next can't possibly be printed. > I don't think I agree. I think it is rather bogus to generate an >initialized structure that is only partially initialized. It would be implicitly initialized as if all fields at the end were set to 0. The comments in ioconf.c now extend past column 132 and don't line up with the code after column 80. The code only extends to about column 105. Bruce