From owner-p4-projects@FreeBSD.ORG Thu Feb 19 18:01:32 2009 Return-Path: Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id 53215106567E; Thu, 19 Feb 2009 18:01:32 +0000 (UTC) Delivered-To: perforce@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0DCB4106567C for ; Thu, 19 Feb 2009 18:01:32 +0000 (UTC) (envelope-from bz@FreeBSD.org) Received: from mail.cksoft.de (mail.cksoft.de [62.111.66.27]) by mx1.freebsd.org (Postfix) with ESMTP id B85AA8FC27 for ; Thu, 19 Feb 2009 18:01:31 +0000 (UTC) (envelope-from bz@FreeBSD.org) Received: from localhost (amavis.str.cksoft.de [192.168.74.71]) by mail.cksoft.de (Postfix) with ESMTP id CF90741C69F; Thu, 19 Feb 2009 18:45:08 +0100 (CET) X-Virus-Scanned: amavisd-new at cksoft.de Received: from mail.cksoft.de ([62.111.66.27]) by localhost (amavis.str.cksoft.de [192.168.74.71]) (amavisd-new, port 10024) with ESMTP id VFPk2rziu-sa; Thu, 19 Feb 2009 18:45:08 +0100 (CET) Received: by mail.cksoft.de (Postfix, from userid 66) id 783FF41C6BB; Thu, 19 Feb 2009 18:45:08 +0100 (CET) Received: from maildrop.int.zabbadoz.net (maildrop.int.zabbadoz.net [10.111.66.10]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.int.zabbadoz.net (Postfix) with ESMTP id 68112444936; Thu, 19 Feb 2009 17:45:04 +0000 (UTC) Date: Thu, 19 Feb 2009 17:45:04 +0000 (UTC) From: "Bjoern A. Zeeb" X-X-Sender: bz@maildrop.int.zabbadoz.net To: Marko Zec In-Reply-To: <200902191824.30353.zec@icir.org> Message-ID: <20090219174342.S53478@maildrop.int.zabbadoz.net> References: <200902191710.n1JHAT4W092138@repoman.freebsd.org> <200902191824.30353.zec@icir.org> X-OpenPGP-Key: 0x14003F198FEFA3E77207EE8D2B58B8F83CCF1842 MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: Perforce Change Reviews , Julian Elischer Subject: Re: PERFORCE change 157941 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Feb 2009 18:01:33 -0000 On Thu, 19 Feb 2009, Marko Zec wrote: > On Thursday 19 February 2009 18:10:29 Julian Elischer wrote: >> http://perforce.freebsd.org/chv.cgi?CH=157941 >> >> Change 157941 by julian@julian_trafmon1 on 2009/02/19 17:09:57 >> >> Implement BZ's fix for altq to compile > > Thanks! > > Amazingly epair now really works with vimages! Though, all cloned > instances always have the same unit number (0)... *huh* are you sure? I'll get my test setup back online so ... and btw. it has worked with vimage before but the ointegrated head had paniced in new-arp somewhere;) Things will be improved along the path I guess, netisr2 from rwatson, proper testing ... >> Affected files ... >> >> .. //depot/projects/vimage/src/sys/net/if_epair.c#5 edit >> >> Differences ... >> >> ==== //depot/projects/vimage/src/sys/net/if_epair.c#5 (text+ko) ==== >> >> @@ -323,12 +323,12 @@ >> >> #ifdef ALTQ >> /* Support ALTQ via the clasic if_start() path. */ >> - IF_LOCK(&epairinq); >> + IF_LOCK(&ifp->if_snd); >> if (ALTQ_IS_ENABLED(&ifp->if_snd)) { >> ALTQ_ENQUEUE(&ifp->if_snd, m, NULL, error); >> if (error) >> ifp->if_snd.ifq_drops++; >> - IF_UNLOCK(&epairinq); >> + IF_UNLOCK(&ifp->if_snd); >> if (!error) { >> ifp->if_obytes += len; >> if (mflags & (M_BCAST|M_MCAST)) >> @@ -341,7 +341,7 @@ >> } >> return (error); >> } >> - IF_UNLOCK(&epairinq); >> + IF_UNLOCK(&ifp->if_snd); >> #endif >> >> if ((epair_drv_flags & IFF_DRV_OACTIVE) != 0) { > > -- Bjoern A. Zeeb The greatest risk is not taking one.