Date: Sat, 11 Feb 2017 16:03:18 +0000 (UTC) From: jbeich@freebsd.org (Jan Beich) To: mmokhi@FreeBSD.org, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r433881 - in head/sysutils: . lttng-tools lttng-tools/files lttng-ust lttng-ust/files Message-ID: <20170211160318.A6D1F3E33@freefall.freebsd.org> In-Reply-To: <201702111536.v1BFaI3i033986@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Mahdi Mokhtari <mmokhi@FreeBSD.org> writes:
> + char tmp_path[PATH_MAX];
> ++#if defined(__FreeBSD__)
> ++ const size_t HOST_NAME_MAX = sysconf(_SC_HOST_NAME_MAX);
> ++#endif
> + char hostname[HOST_NAME_MAX];
[...]
> + struct ltt_session {
> + char name[NAME_MAX];
> ++#if defined(__FreeBSD__)
> ++ char hostname[256]; /* Local hostname. */
> ++#else
> + char hostname[HOST_NAME_MAX]; /* Local hostname. */
> ++#endif
Why do you mix constant and sysconf() usage?
> + #if (defined(__FreeBSD__) || defined(__CYGWIN__))
> + typedef long long off64_t;
> + #endif
FreeBSD 11.0 or later define off64_t as an alias for off_t aka int64_t
which is "long" (not "long long") on amd64. Is the conflicting
definition intentional?
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20170211160318.A6D1F3E33>