From owner-svn-src-projects@FreeBSD.ORG Tue Sep 18 15:30:59 2012 Return-Path: Delivered-To: svn-src-projects@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 70C8D106564A; Tue, 18 Sep 2012 15:30:59 +0000 (UTC) (envelope-from asmrookie@gmail.com) Received: from mail-lb0-f182.google.com (mail-lb0-f182.google.com [209.85.217.182]) by mx1.freebsd.org (Postfix) with ESMTP id CBB968FC08; Tue, 18 Sep 2012 15:30:57 +0000 (UTC) Received: by lbbgg13 with SMTP id gg13so117939lbb.13 for ; Tue, 18 Sep 2012 08:30:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:reply-to:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; bh=klxUElMZ5fHhpEttMNMvAfZgeIDjIPwYXiyLQx/keKE=; b=TcVOyF/BafIidfKm//bRBRZE/LwPRCMU7gcl/qLY2C+s6aqpyhr7Y0an/iv5/fTSe8 KQsSbEVsyK+1RlnKYjQe3vuAzNwp6z7rKlyd96iDfU0jMIZ7rVgbG+SNFbawlad2kTad brRu1ZcyvvTt18WraQx0VXZIZ/ZbYXOMpNA0sxZj9R0mkegCZQEDZGfssIQRN2pTdHmo zKN8kZwajlo7p8Cq1/W8mEi2HhBMsFi7sSDjfZyr7ID0fLGbxcyPYS+Hjy208C7/4BHl +/4ExdpEoCUFZd/rsQlXKWVmv8PvlweidYl/aJ01S0DT2vUeeTwxhSVTkJ8MDUssWOeT ibOg== MIME-Version: 1.0 Received: by 10.152.144.2 with SMTP id si2mr169230lab.26.1347982256293; Tue, 18 Sep 2012 08:30:56 -0700 (PDT) Sender: asmrookie@gmail.com Received: by 10.112.102.39 with HTTP; Tue, 18 Sep 2012 08:30:56 -0700 (PDT) In-Reply-To: <20120918083324.GX37286@deviant.kiev.zoral.com.ua> References: <201207301350.q6UDobCI099069@svn.freebsd.org> <201207301732.33474.jhb@freebsd.org> <20120918083324.GX37286@deviant.kiev.zoral.com.ua> Date: Tue, 18 Sep 2012 16:30:56 +0100 X-Google-Sender-Auth: _eIgAW_HzzeZcnLfkKj4Mobt8Ws Message-ID: From: Attilio Rao To: Konstantin Belousov Content-Type: text/plain; charset=UTF-8 Cc: Davide Italiano , src-committers@freebsd.org, John Baldwin , Jeff Roberson , Dimitry Andric , svn-src-projects@freebsd.org Subject: Re: svn commit: r238907 - projects/calloutng/sys/kern X-BeenThere: svn-src-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: attilio@FreeBSD.org List-Id: "SVN commit messages for the src " projects" tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Sep 2012 15:30:59 -0000 On 9/18/12, Konstantin Belousov wrote: > On Tue, Sep 18, 2012 at 01:13:08AM +0100, Attilio Rao wrote: >> diff --git a/sys/sys/cdefs.h b/sys/sys/cdefs.h >> index 8224672..fc6a75f 100644 >> --- a/sys/sys/cdefs.h >> +++ b/sys/sys/cdefs.h >> @@ -114,6 +114,13 @@ >> #endif >> >> /* >> + * Compiler memory barriers, specific to gcc and clang. >> + */ >> +#if defined(__GNUC__) >> +#define __compiler_membar() __asm __volatile(" " : : : >> "memory") >> +#endif >> + >> +/* > > Traditionally, we do provide the fallback for non-GNUC compilers, by > defining extern function with the compatible signature. In this case, > the empty function just works for the purpose, although with higher > overhead than the GNUC case. I agree, we need a fallback here. Unfortunately I'm buried with job stuff but I will provide an errata patch ASAP. Thanks, Attilio -- Peace can only be achieved by understanding - A. Einstein