From owner-freebsd-current@FreeBSD.ORG Sun Sep 5 08:06:23 2004 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DEFF716A4CE; Sun, 5 Sep 2004 08:06:23 +0000 (GMT) Received: from cpanel.ezone.ru (cpanel.ezone.ru [213.85.31.234]) by mx1.FreeBSD.org (Postfix) with ESMTP id BF7BE43D2D; Sun, 5 Sep 2004 08:06:22 +0000 (GMT) (envelope-from mcsi@mcsi.pp.ru) Received: from [81.195.2.133] (ppp2-133.pppoe.mtu-net.ru [81.195.2.133]) (authenticated bits=0) by cpanel.ezone.ru (8.13.1/8.12.11) with ESMTP id i8586ETP051520; Sun, 5 Sep 2004 12:06:15 +0400 (MSD) (envelope-from mcsi@mcsi.pp.ru) Message-ID: <413AC8F1.9020601@mcsi.pp.ru> Date: Sun, 05 Sep 2004 12:06:09 +0400 From: Maxim Maximov User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.7.2) Gecko/20040810 X-Accept-Language: ru, en-us, en MIME-Version: 1.0 To: Robert Watson References: In-Reply-To: Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, hits=-4.9 required=5.0 tests=BAYES_00 autolearn=ham version=2.64 X-Spam-Checker-Version: SpamAssassin 2.64 (2004-01-11) on mail3.ezone.ru cc: freebsd-current@freebsd.org Subject: Re: [PATCH] poll() hang with X apps X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 05 Sep 2004 08:06:24 -0000 Robert Watson wrote: > On Sun, 5 Sep 2004, Maxim Maximov wrote: > > >>Doug White wrote: >> >>>Attaching to an earlier message here... >>> >>>rwatson and I may have a solution to the poll() hangs you have been >>>experiencing. Try downloading and applying this patch: >>> >>>http://www.watson.org/~robert/freebsd/netperf/20040905-sopoll.diff >>> >>>This seems to stop the hangs on my test system (2x600MHz P3 with XFree >>>4.3). I'll test it with its partner, a RELENG_5 box with either Xorg or >>>XFree86 4.4. Please test it and get back to us if its working for you. >> >>Oh my! I'm recompiling my kernel already! >> >>I began to think that this problem was abandoned, but there were work >>going on! Thank you and Robert! > > > Yeah, I had a good idea about what the problem might be, but I couldn't > reproduce it here. Happily, Doug could and was willing to spend a lot of > time with the debugger to track stuff down. Turns out it may have been a > potential race I tagged when I was originally reviewing that element of > socket locking, but hadn't yet had a chance to revisit. If the patch > fixes it, wonderful! If not, there are one or two other things in the > polling/select code that could use review. Assuming this patch does fix > the problem for you (it did for Doug), I'll get it merged into HEAD > tomorrow, and RELENG_5 a few days later. > > Thanks for your bug report, and we'll see how it goes :-). It goes very well. Easily reproducible xscreensaver hacks hangs described by Doug are gone for me too. I believe the patch also solves my dockapp problems. I haven't seen any wmdockapps hangs yet, but they are harder to reproduce, so only time will tell. I guess this patch should be merged anyway. At least for xscreensaver related hangs :) -- Maxim Maximov