Date: Fri, 8 May 2015 17:13:50 -0400 From: "Philip M. Gollucci" <pgollucci@p6m7g8.com> To: Bryan Drewery <bdrewery@freebsd.org> Cc: Mathieu Arnold <mat@freebsd.org>, Sunpoet Po-Chuan Hsieh <sunpoet@freebsd.org>, Matthew Seaman <matthew@freebsd.org>, "ports-committers@freebsd.org" <ports-committers@freebsd.org>, "svn-ports-all@freebsd.org" <svn-ports-all@freebsd.org>, "svn-ports-head@freebsd.org" <svn-ports-head@freebsd.org> Subject: Re: svn commit: r385776 - in head/sysutils: . rubygem-hiera-file Message-ID: <CACM2dAZo09Yim9o0vqGGVH4ogy-jzdb66ZFYF50k%2BYx-vNgS6g@mail.gmail.com> In-Reply-To: <554CDE6C.6000302@FreeBSD.org> References: <201505081305.t48D5ULi055835@svn.freebsd.org> <CAMHz58SAcjiCprFNT_x0xgg6ceBzhh0s%2BBgYj1uo%2BDQ96rVEyA@mail.gmail.com> <554CD6C9.5000708@FreeBSD.org> <CAMHz58Qk1RfOfh%2BrfaJoFVz5%2B5ij3BxmQQ1a87c2nCtp%2BoBZyA@mail.gmail.com> <554CDBE8.7020703@FreeBSD.org> <5AA4F2DD682E895BAD92C3A8@atuin.in.mat.cc> <554CDE6C.6000302@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Its also documented in the PBH to do what portlint says. I like the consistency but have no overall opinion. On Fri, May 8, 2015 at 12:03 PM, Bryan Drewery <bdrewery@freebsd.org> wrote: > On 5/8/2015 11:00 AM, Mathieu Arnold wrote: > > +--On 8 mai 2015 10:53:12 -0500 Bryan Drewery <bdrewery@FreeBSD.org> > wrote: > > |> > > |> % portlint -abct > > |> WARN: Makefile: Consider defining LICENSE. > > |> WARN: Makefile: "RUN_DEPENDS" has to appear earlier. > > |> 0 fatal errors and 2 warnings found. > > | > > | This rule serves no purpose. > > > > I don't really agree, from make's point of view, it does not, but from > the > > point of view of us all having to maintain a bunch of Makefiles, if the > > order of the group of fields is always consistent, it's easier to read. > > > > But it's not, and it's not possible to do so. Consider OPTION-based > DEPENDS. See www/nginx/Makefile as an example. This rule will never be > consistent and it's a pointless rule that serves only to annoy people. > > -- > Regards, > Bryan Drewery > > -- --------------------------------------------------------------------------------- Curb: Your ride is here 4096R/D1EAB94D 2081 E230 3001 6508 8847 1BBF A0A8 DB0F D1EA B94D Philip M. Gollucci (pgollucci@p6m7g8.com) c: 703.336.9354 Member, Apache Software Foundation Committer, FreeBSD Foundation Consultant, P6M7G8 Inc. Sr. Director IT Operations, Curb What doesn't kill us can only make us stronger; Except it almost kills you.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CACM2dAZo09Yim9o0vqGGVH4ogy-jzdb66ZFYF50k%2BYx-vNgS6g>