Date: Sun, 16 Feb 2014 17:00:02 GMT From: Andriy Gapon <avg@FreeBSD.org> To: freebsd-bugs@FreeBSD.org Subject: Re: kern/184092: zfs zvol devices are not appearing till after reimport of pool Message-ID: <201402161700.s1GH02fL045425@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR kern/184092; it has been noted by GNATS. From: Andriy Gapon <avg@FreeBSD.org> To: d@delphij.net, Christopher Harrison <harrison@glsan.com>, freebsd-gnats-submit@FreeBSD.org Cc: Subject: Re: kern/184092: zfs zvol devices are not appearing till after reimport of pool Date: Sun, 16 Feb 2014 18:52:20 +0200 on 19/11/2013 20:50 Xin Li said the following: > I think Andriy (cc'ed) have fixed a similar issue. A quick glance at the > code suggests maybe we can use something like this: I am not sure if I have ever fixed this -- if you have a reference then please share with :-) But the change looks good to me and I also think that Steve Hartland proposed this change as well. Thanks! And sorry for the delay with my reply. > Index: sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_ioctl.c > =================================================================== --- > sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_ioctl.c (revision > 258350) +++ sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_ioctl.c > (working copy) @@ -3298,6 +3298,10 @@ zfs_ioc_clone(const char *fsname, > nvlist_t *innvl, if (error != 0) (void) dsl_destroy_head(fsname); } +#ifdef > __FreeBSD__ + if (error == 0) + > zvol_create_minors(fsname); +#endif return (error); } > > Can you confirm if this helps? > > (I think we should use a better way to trigger zvol_create_minor, maybe via > a devfs lookup hook?) > > Cheers, > -- Andriy Gapon
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201402161700.s1GH02fL045425>