Date: Sun, 24 Oct 2004 17:58:32 +0000 From: Xin LI <delphij@FreeBSD.org> To: Ken Smith <kensmith@cse.Buffalo.EDU> Cc: src-committers@FreeBSD.org Subject: Re: cvs commit: src/release/doc/zh_CN.GB2312/readme article.sgml Message-ID: <20041024175832.GA41616@freefall.freebsd.org> In-Reply-To: <20041024173047.GA11644@electra.cse.Buffalo.EDU> References: <200410241219.i9OCJ5PF089751@repoman.freebsd.org> <20041024173047.GA11644@electra.cse.Buffalo.EDU>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi, Ken On Sun, Oct 24, 2004 at 01:30:47PM -0400, Ken Smith wrote: > What would I have needed to do to catch this? I tested with a 'make lint' > before committing and I had a successful release build afterwards. Sigh... It's my fault :-( I have tested it before I have requested the tag slip however I have not sync'ed the whole tree. In order to make sure a localized version of the release documentation tree can build, one way is to chdir to the directory holding it, like src/release/doc/zh_CN.GB2312 and run ``make all''. Locallized documentations are not built by default (and I think it is not built in normal make buildworld process). Long story: On the day I am going to commit these documentations I have adopted these documentations to -HEAD. So I have did the following: - cd release/doc/ && cvs -R up -A - cp ~/tmp/zh_CN.GB2312 . - make Then I got some error complaining about release.type.current. I found the answer in English edition and hacked readme/ then it builds correctly. With this result and having checked the output on my local box I believed that there is nothing wrong with it and requested the approval to commit. Because the documentation is originally tested under RELENG_5 extensively I didn't noticed the difference in share/. Then I have requested the tag slip. Seeing Scott's headsup I have decided to add these documentations into the ongoing www/ tree and I did a clean checkout then found the issue. So finally I got my own pointy hat? :-) Cheers,
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20041024175832.GA41616>