From owner-cvs-all@FreeBSD.ORG  Sun Oct 24 17:58:32 2004
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 832FB16A4CF; Sun, 24 Oct 2004 17:58:32 +0000 (GMT)
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 6993743D2F; Sun, 24 Oct 2004 17:58:32 +0000 (GMT)
	(envelope-from delphij@FreeBSD.org)
Received: from freefall.freebsd.org (delphij@localhost [127.0.0.1])
	i9OHwWGc042053;	Sun, 24 Oct 2004 17:58:32 GMT
	(envelope-from delphij@freefall.freebsd.org)
Received: (from delphij@localhost)
	by freefall.freebsd.org (8.12.11/8.12.11/Submit) id i9OHwWAh042052;
	Sun, 24 Oct 2004 17:58:32 GMT
	(envelope-from delphij)
Date: Sun, 24 Oct 2004 17:58:32 +0000
From: Xin LI <delphij@FreeBSD.org>
To: Ken Smith <kensmith@cse.Buffalo.EDU>
Message-ID: <20041024175832.GA41616@freefall.freebsd.org>
References: <200410241219.i9OCJ5PF089751@repoman.freebsd.org>
	<20041024173047.GA11644@electra.cse.Buffalo.EDU>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20041024173047.GA11644@electra.cse.Buffalo.EDU>
User-Agent: Mutt/1.4.1i
cc: cvs-src@FreeBSD.org
cc: Hiroki Sato <hrs@FreeBSD.org>
cc: cvs-all@FreeBSD.org
cc: src-committers@FreeBSD.org
Subject: Re: cvs commit: src/release/doc/zh_CN.GB2312/readme article.sgml
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 24 Oct 2004 17:58:32 -0000

Hi, Ken

On Sun, Oct 24, 2004 at 01:30:47PM -0400, Ken Smith wrote:
> What would I have needed to do to catch this?  I tested with a 'make lint'
> before committing and I had a successful release build afterwards.

Sigh... It's my fault :-(  I have tested it before I have requested the tag
slip however I have not sync'ed the whole tree.

In order to make sure a localized version of the release documentation
tree can build, one way is to chdir to the directory holding it,
like src/release/doc/zh_CN.GB2312 and run ``make all''.  Locallized
documentations are not built by default (and I think it is not built
in normal make buildworld process).

Long story:

On the day I am going to commit these documentations I have adopted
these documentations to -HEAD.  So I have did the following:

	- cd release/doc/ && cvs -R up -A
	- cp ~/tmp/zh_CN.GB2312 .
	- make

Then I got some error complaining about release.type.current.  I
found the answer in English edition and hacked readme/ then it
builds correctly.

With this result and having checked the output on my local box
I believed that there is nothing wrong with it and requested the
approval to commit.

Because the documentation is originally tested under RELENG_5
extensively I didn't noticed the difference in share/.  Then I
have requested the tag slip.

Seeing Scott's headsup I have decided to add these documentations
into the ongoing www/ tree and I did a clean checkout then found
the issue.

So finally I got my own pointy hat? :-)

Cheers,