Date: Thu, 28 Jan 2010 13:16:43 -0800 From: Xin LI <delphij@delphij.net> To: freebsd-ports@freebsd.org Subject: Re: patch upgrade for port committers? Message-ID: <4B61FEBB.7050503@delphij.net> In-Reply-To: <4B61E988.1000801@missouri.edu> References: <4B61E988.1000801@missouri.edu>
next in thread | previous in thread | raw e-mail | index | archive | help
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 2010/01/28 11:46, Stephen Montgomery-Smith wrote: > When an update to a port is committed, it is likely to contain > > (a) lines like "Only in xxxx: yyyy" > > or (b) patches that are created against empty files using the "-N" > option for diff. > > Cannot "patch" honor these cases? As a port maintainer, I have been > caught quite a few times by committers not adding or removing files from > the "files" directory in a port. For patch to remove files one can specify -E; I think ports committers are responsible to take care for adding/removing files. It's advisable for committers to do 'portlint - -C' and a full 'port test' (porttools) run at minimum... Cheers, - -- Xin LI <delphij@delphij.net> http://www.delphij.net/ FreeBSD - The Power to Serve! Live free or die -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.14 (FreeBSD) iQEcBAEBAgAGBQJLYf67AAoJEATO+BI/yjfB830H/il+N/9xzGfECkPYdErNhHIF yCRgvrXWqcRv8fy8O2cg0I3reXacxADj9ex+sl4o8wVKBuAJJQv0zSvhBTVIaxyl bsWThyqf523AE70qmfew2vtsH8nCf4lZVwI9relVpvOOgcCAZcC5Tjj04HU+nbcl 9c/HJJdQmfZcIsYOEU7K38aX7Ip7hgX/JzkZ1gPQWwLH+XdKAkruChjk3vKbbBFy ZG2EnevcZDwC4e1/354x+1imTg2Jh2BYDuU0eXHnaVfkYInmjHEvE12w5Mtxy8H1 SLQw4mEz1F51TedgUd2uWSY7j91K24AQzo/q99D2C2GYlA/ZX/AJyBVPP2bFXRY= =/7DD -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4B61FEBB.7050503>