Date: Sun, 20 Apr 2014 10:33:29 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: Antoine Brodin <antoine@FreeBSD.org> Cc: "svn-ports-head@freebsd.org" <svn-ports-head@freebsd.org>, "svn-ports-all@freebsd.org" <svn-ports-all@freebsd.org>, "ports-committers@freebsd.org" <ports-committers@freebsd.org>, Mathieu Arnold <mat@freebsd.org>, Bryan Drewery <bdrewery@freebsd.org>, Adam Weinberger <adamw@adamw.org> Subject: Re: Commit logs for 2014/04/11 Message-ID: <20140420103329.GB7694@FreeBSD.org> In-Reply-To: <CAALwa8=zYC8Gf9O7vmq6L-NoKJEvmWVPb9m3O7SwbHvNS1LPtA@mail.gmail.com> References: <20140412035900.3C695121E45@apnoea.adamw.org> <EA3162FC-904F-4209-81D8-67CDADA357A2@adamw.org> <20140420092922.GA90642@FreeBSD.org> <B8427660C28547FE27FAF9F7@atuin.in.mat.cc> <20140420101807.GA7694@FreeBSD.org> <CAALwa8=zYC8Gf9O7vmq6L-NoKJEvmWVPb9m3O7SwbHvNS1LPtA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Apr 20, 2014 at 12:22:12PM +0200, Antoine Brodin wrote: > On Sun, Apr 20, 2014 at 12:18 PM, Alexey Dokuchaev <danfe@freebsd.org> wrote: > > I mean it is not hardcoded inside /usr/ports/Keywords/pkg_install.awk. > > I'm not familiar with /usr/ports/Keywords/sample.yaml to quickly come up > > with a patch, but suspect it would also be simple to make it generic. > > It's definitely better to be consistent and use .sample everywhere. It depends on one's particular definition of "consistency". Consistent with other ports within our Ports Collection? Or, like Adam mentioned, consistent with the upstream and/or most GNU/Linux distros' own scheme? I'm also afraid that ".sample" won't be appropriate in 100% cases; sometimes other suffixes might work better, I think. ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20140420103329.GB7694>