From owner-freebsd-ppc@freebsd.org Thu Jan 9 23:31:53 2020 Return-Path: Delivered-To: freebsd-ppc@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id F23101FCC10 for ; Thu, 9 Jan 2020 23:31:53 +0000 (UTC) (envelope-from marklmi@yahoo.com) Received: from sonic315-55.consmr.mail.gq1.yahoo.com (sonic315-55.consmr.mail.gq1.yahoo.com [98.137.65.31]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 47v2Sm4pM6z3Nqv for ; Thu, 9 Jan 2020 23:31:52 +0000 (UTC) (envelope-from marklmi@yahoo.com) X-YMail-OSG: SFGLtUoVM1nl_OmXEBf1m7_dRVS.VaKIvrlWDf0stMpLQyrPxE7EEHyM34MQqsV 5S.LNuSyQBM0Jo4za6XjeuSrkLXRwTiDlaeqjqzVCjU0B7dL6SZjDn69u5K9SL5atNHzEOHFrAiY DtQkIZbVSMi2xjJp11RdIaBjQbI_UZUhu2SaJIy38OuFChGnHhBqWapsPyW5nKgjScjld7qbEhmP JmgFb5ZmA7sGIZf.5NFHd_.fzJ5.EzYr7nEeVf8br8F.aKwkzpz27Lx9Eqoa42r_upxHOeRYqcX4 ysiEk0_RTjGsv7Xh1LvFTfQo9m3YpNpvoE30F6yFJ8xBuG10nFgGFX6nvbj0Uy8tZLRuyTIN1sZ3 SQTQhob2MU0gn7jVozXcy07zT65tNPAIdm3YYxID.J5iQfS3ls35pWAXkkWcKYvrKIvdJ_S9YUhS 13SiBU.WdgwdiADDfJnewOoKZ21ewGtP2tcjC6_DK3X5YGEt5ab8jXO7_gUNaWq1fkbrxbjHl.cG kUKSSegxkHMC8hZ.iCJnBEjBZP2hBukWy1zRFDHyKhOFWv3GXd7BxmIxMn_wREKgAEYnXNbZm97a RFDkeisow_jZSHSicVFUNpU05zbmgbvra6IpgBY3avvb_ykR92r0IwVg4PIfblCjRbOtksBHqySZ LVKu1ULYiyrnttjlDsVYGfB86blxYlsSPG8E1t1mctvgowyUqW_WSfK7wXuMW3tGlZ1bhL8jmXfu __v9jjbKBWUtfxw8_8qLuTythM4mE4jFI53P85sVVAHe.X.VdoT.MDFCudCYHmE.Q1XP46o7tObp wsnBwyE8keCw9emWkHc_iqTagsYWU0Ysf4h_PWIdssXllp4nzbIXOiH0K2et6MNm0ZVrquU0Zen9 SKWMd9bqBEeeMADhC4InOC5gDsWFcWJMcXyPMiJV8VVaMaK7OKiwVq6ZAjl.9RLacur7DCcTWtcw Uil_osiXJgdiy5.IITNZAn8yQG2PkcJ2Wc9hJctznvvuv7LRPKKKD23qrcatyY60YgsJ3gXQtDff 5q5pL0EbcibnpBkxiIU.2FOInW4P.Dh_Yk6Lv7RZ0G8lgvURkfVeETSMw.v4sSqCKUp5fPyrgh67 CkwTDtn433pJ5fMNW0qWRMKpyOe_Dx53PcVXIWF3RTinDZcm_sucEszXZL_FCZ9pVtvoffObg2vL iPg51R8DieH9EW5ILPdtq6X94zviYgLtBIu2UfS4r7r.CbRcmFWyJXU8xZ0fxQ_OfsA6ws7xS77R Phg_P7VXVofvkf_XFkhncwlVocD1Mkos7kLBSFsrMqNzBA1pSD9y8.B5qvom6dRuVl0Gz9uVDlQ9 Il0KGNoQmJ0KF7BaSy4bo8AkkwHA7LsnMPdrtMMWCHvo5XO3yAMK1VJkPVIWqJjL86RreV1G6nzN hWQROusg_mx5Lgas9Nm_GBEXtlP1jiY0Qi98- Received: from sonic.gate.mail.ne1.yahoo.com by sonic315.consmr.mail.gq1.yahoo.com with HTTP; Thu, 9 Jan 2020 23:31:50 +0000 Received: by smtp422.mail.gq1.yahoo.com (Oath Hermes SMTP Server) with ESMTPA ID 917fdf2b9588ddf31feddb84f1659224; Thu, 09 Jan 2020 23:31:48 +0000 (UTC) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 13.0 \(3608.40.2.2.4\)) Subject: Re: A possible unbounded loop in moea_sync_icache: why sys/vm/mlock_test:mlock__copy_on_write_vnode fails? From: Mark Millard In-Reply-To: Date: Thu, 9 Jan 2020 15:31:47 -0800 Cc: Justin Hibbits , FreeBSD PowerPC ML , "bdragon@freebsd.org" Content-Transfer-Encoding: quoted-printable Message-Id: References: <022334D3-B60E-440F-A514-8D8002B65CB4.ref@yahoo.com> <022334D3-B60E-440F-A514-8D8002B65CB4@yahoo.com> To: Leandro Lupori X-Mailer: Apple Mail (2.3608.40.2.2.4) X-Rspamd-Queue-Id: 47v2Sm4pM6z3Nqv X-Spamd-Bar: + X-Spamd-Result: default: False [1.18 / 15.00]; TO_DN_EQ_ADDR_SOME(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ptr:yahoo.com]; FREEMAIL_FROM(0.00)[yahoo.com]; MV_CASE(0.50)[]; DKIM_TRACE(0.00)[yahoo.com:+]; DMARC_POLICY_ALLOW(-0.50)[yahoo.com,reject]; FREEMAIL_TO(0.00)[gmail.com]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; SUBJECT_ENDS_QUESTION(1.00)[]; FREEMAIL_ENVFROM(0.00)[yahoo.com]; ASN(0.00)[asn:36647, ipnet:98.137.64.0/21, country:US]; MID_RHS_MATCH_FROM(0.00)[]; DWL_DNSWL_NONE(0.00)[yahoo.com.dwl.dnswl.org : 127.0.5.0]; ARC_NA(0.00)[]; R_DKIM_ALLOW(-0.20)[yahoo.com:s=s2048]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; TAGGED_RCPT(0.00)[]; MIME_GOOD(-0.10)[text/plain]; NEURAL_SPAM_MEDIUM(0.31)[0.306,0]; IP_SCORE_FREEMAIL(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; NEURAL_SPAM_LONG(0.38)[0.376,0]; RCVD_IN_DNSWL_NONE(0.00)[31.65.137.98.list.dnswl.org : 127.0.5.0]; RCVD_TLS_LAST(0.00)[]; FREEMAIL_CC(0.00)[gmail.com]; RCVD_COUNT_TWO(0.00)[2]; IP_SCORE(0.00)[ip: (4.75), ipnet: 98.137.64.0/21(0.87), asn: 36647(0.70), country: US(-0.05)] X-BeenThere: freebsd-ppc@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Porting FreeBSD to the PowerPC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Jan 2020 23:31:54 -0000 On 2020-Jan-9, at 03:12, Leandro Lupori = wrote: > Interesting, this looks like the same issue that was fixed on 64-bit = some time ago: https://reviews.freebsd.org/D19149. I changed my local code to use va+1 as in that update and can confirm that I now get: # kyua test -k /usr/tests/Kyuafile sys/vm/mlock_test sys/vm/mlock_test:mlock__copy_on_write_anon -> passed [0.018s] sys/vm/mlock_test:mlock__copy_on_write_vnode -> passed [0.008s] sys/vm/mlock_test:mlock__truncate_and_resize -> passed [0.019s] sys/vm/mlock_test:mlock__truncate_and_unlock -> passed [0.019s] > On Thu, Jan 9, 2020 at 3:03 AM Mark Millard via freebsd-ppc = wrote: >> . . . >> The code in question: >>=20 >> static void >> moea_sync_icache(mmu_t mmu, pmap_t pm, vm_offset_t va, vm_size_t sz) >> { =20 >> struct pvo_entry *pvo; >> vm_offset_t lim; >> vm_paddr_t pa; >> vm_size_t len; >>=20 >> PMAP_LOCK(pm); >> while (sz > 0) { >> lim =3D round_page(va); The above line is where I changed the va to be va+1 . >> len =3D MIN(lim - va, sz); >> pvo =3D moea_pvo_find_va(pm, va & ~ADDR_POFF, NULL); >> if (pvo !=3D NULL) { >> pa =3D (pvo->pvo_pte.pte.pte_lo & PTE_RPGN) | >> (va & ADDR_POFF); >> moea_syncicache(pa, len); >> } >> va +=3D len; >> sz -=3D len; >> } >> PMAP_UNLOCK(pm); >> } >=20 =3D=3D=3D Mark Millard marklmi at yahoo.com ( dsl-only.net went away in early 2018-Mar)