From owner-freebsd-current@FreeBSD.ORG Sun Sep 17 06:50:53 2006 Return-Path: X-Original-To: current@freebsd.org Delivered-To: freebsd-current@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C36B516A403 for ; Sun, 17 Sep 2006 06:50:53 +0000 (UTC) (envelope-from thompsa@freebsd.org) Received: from grunt8.ihug.co.nz (grunt8.ihug.co.nz [203.109.254.48]) by mx1.FreeBSD.org (Postfix) with ESMTP id 75B0443D62 for ; Sun, 17 Sep 2006 06:50:52 +0000 (GMT) (envelope-from thompsa@freebsd.org) Received: from 203-109-251-39.static.bliink.ihug.co.nz (heff.fud.org.nz) [203.109.251.39] by grunt8.ihug.co.nz with esmtp (Exim 3.35 #1 (Debian)) id 1GOqUH-0002ue-00; Sun, 17 Sep 2006 18:50:45 +1200 Received: by heff.fud.org.nz (Postfix, from userid 1001) id 41DD21CC26; Sun, 17 Sep 2006 18:50:44 +1200 (NZST) Date: Sun, 17 Sep 2006 18:50:44 +1200 From: Andrew Thompson To: John Baldwin Message-ID: <20060917065044.GA57195@heff.fud.org.nz> Mail-Followup-To: Andrew Thompson , John Baldwin , Andre Oppermann , current@freebsd.org, freebsd-current@freebsd.org, Mike Tancsa , Ian FREISLICH , Gleb Smirnoff , Jack Vogel References: <20060915102228.GK27667@FreeBSD.org> <450A8467.5050405@freebsd.org> <200609151014.36785.jhb@freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200609151014.36785.jhb@freebsd.org> User-Agent: Mutt/1.5.11 Cc: Andre Oppermann , current@freebsd.org, Mike Tancsa , Ian FREISLICH , freebsd-current@freebsd.org, Gleb Smirnoff , Jack Vogel Subject: Re: TSO, SMP and the em driver. X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 17 Sep 2006 06:50:53 -0000 On Fri, Sep 15, 2006 at 10:14:35AM -0400, John Baldwin wrote: > On Friday 15 September 2006 06:45, Andre Oppermann wrote: > > Gleb Smirnoff wrote: > > > On Wed, Sep 13, 2006 at 10:46:22AM -0500, Brooks Davis wrote: > > > B> On Wed, Sep 13, 2006 at 11:08:44AM -0400, John Baldwin wrote: > > > B> > On Tuesday 12 September 2006 19:14, Andre Oppermann wrote: > > > B> > > Mike Tancsa wrote: > > > B> > > > At 12:43 PM 9/12/2006, Andre Oppermann wrote: > > > B> > > > B> I'm not sure it's worth worrying about with GbE hardware. Just disable > > > B> TSO in promiscuous mode. Where TSO is going to really matter is 10GbE. > > > B> No supporting TSO in some configurations with GbE doesn't seem like a > > > B> big deal to me. > > > > > > Yes, makeing TSO and promisc mutually exclusive would be fine. > > > > There is no point in disabling TSO in when the card is in promisc mode. > > Promisc mode only affects the receive path where TSO doesn't do a thing, > > it is only used on the send path. > > The real fix is that the network stack including bpf(4) needs to be aware > of VLANs that aren't stored in the packet data (mtag, mbuf header, > wherever). If you fixed bridging and bpf to recoginize VLAN IDs in metadata > and handle them then em(4) wouldn't need this hack. Also, if my understanding > is correct, this hack is really needed for _any_ ethernet driver that supports > vlan tagging in hardware unless we fix the stack consumers. I have a patch ready that makes the bridge use the new ether_vlan field when it gets committed. Andrew