From owner-freebsd-hackers@freebsd.org  Sat Feb 24 22:24:48 2018
Return-Path: <owner-freebsd-hackers@freebsd.org>
Delivered-To: freebsd-hackers@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id B8139F284DF;
 Sat, 24 Feb 2018 22:24:48 +0000 (UTC) (envelope-from joerg@bec.de)
Received: from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net
 [IPv6:2001:4b98:c:538::195])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 532C07ACD8;
 Sat, 24 Feb 2018 22:24:48 +0000 (UTC) (envelope-from joerg@bec.de)
Received: from britannica.bec.de
 (p200300D2ABCCC4104639C4FFFE599710.dip0.t-ipconnect.de
 [IPv6:2003:d2:abcc:c410:4639:c4ff:fe59:9710])
 (Authenticated sender: joerg@bec.de)
 by relay3-d.mail.gandi.net (Postfix) with ESMTPSA id ECF8DA80C6;
 Sat, 24 Feb 2018 23:24:44 +0100 (CET)
Date: Sat, 24 Feb 2018 23:23:46 +0100
From: Joerg Sonnenberger <joerg@bec.de>
To: Eitan Adler <lists@eitanadler.com>
Cc: Jilles Tjoelker <jilles@stack.nl>,
 FreeBSD Hackers <freebsd-hackers@freebsd.org>,
 Garrett Wollman <wollman@csail.mit.edu>,
 FreeBSD Standards <freebsd-standards@freebsd.org>
Subject: Re: Marking select(2) as restrict
Message-ID: <20180224222346.GB16529@britannica.bec.de>
Mail-Followup-To: Eitan Adler <lists@eitanadler.com>,
 Jilles Tjoelker <jilles@stack.nl>,
 FreeBSD Hackers <freebsd-hackers@freebsd.org>,
 Garrett Wollman <wollman@csail.mit.edu>,
 FreeBSD Standards <freebsd-standards@freebsd.org>
References: <CAF6rxg=wNVgDUF9o744ngmzPNeHB3hqdrLufy=yS3D4osczxFQ@mail.gmail.com>
 <20180221104400.GU94212@kib.kiev.ua>
 <23181.46427.671514.319710@khavrinen.csail.mit.edu>
 <20180221185920.GA94212@kib.kiev.ua>
 <23181.50488.186767.579361@khavrinen.csail.mit.edu>
 <20180221201002.GC94212@kib.kiev.ua>
 <23181.54825.511195.393054@khavrinen.csail.mit.edu>
 <20180222212746.GB58772@stack.nl>
 <CAF6rxgkW=Fgh4+1-aJG=VUCYso9gcKnER17UOiBy8GtTMsJNYQ@mail.gmail.com>
 <CAF6rxg=-nBz8caa1Wn1Labn3DydpEO6B8W9PaLhNKYFwGvuZxw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAF6rxg=-nBz8caa1Wn1Labn3DydpEO6B8W9PaLhNKYFwGvuZxw@mail.gmail.com>
User-Agent: Mutt/1.9.0 (2017-09-02)
X-BeenThere: freebsd-hackers@freebsd.org
X-Mailman-Version: 2.1.25
Precedence: list
List-Id: Technical Discussions relating to FreeBSD
 <freebsd-hackers.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-hackers>, 
 <mailto:freebsd-hackers-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-hackers/>
List-Post: <mailto:freebsd-hackers@freebsd.org>
List-Help: <mailto:freebsd-hackers-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-hackers>, 
 <mailto:freebsd-hackers-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 24 Feb 2018 22:24:48 -0000

On Sat, Feb 24, 2018 at 10:35:23AM -0800, Eitan Adler wrote:
> The main concern is that things /might/ break in undetectable was.

This argument puzzles me quite a bit. The code here is *already* broken
and depends on unspecified behavior of the kernel, i.e. the order in
which the fdsets are copied in/out.

Joerg