From owner-freebsd-perl@FreeBSD.ORG Sat Mar 17 22:53:02 2012 Return-Path: Delivered-To: perl@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 30203106566B for ; Sat, 17 Mar 2012 22:53:02 +0000 (UTC) (envelope-from swills@FreeBSD.org) Received: from mouf.net (unknown [IPv6:2607:fc50:0:4400:216:3eff:fe69:33b2]) by mx1.freebsd.org (Postfix) with ESMTP id E03C18FC19 for ; Sat, 17 Mar 2012 22:53:01 +0000 (UTC) Received: from meatwad.mouf.net (cpe-024-162-230-236.nc.res.rr.com [24.162.230.236]) (authenticated bits=0) by mouf.net (8.14.4/8.14.4) with ESMTP id q2HMr0rI054207 (version=TLSv1/SSLv3 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NOT); Sat, 17 Mar 2012 18:53:01 -0400 (EDT) (envelope-from swills@FreeBSD.org) Message-ID: <4F6515CC.8000807@FreeBSD.org> Date: Sat, 17 Mar 2012 18:53:00 -0400 From: Steve Wills User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:10.0.2) Gecko/20120302 Thunderbird/10.0.2 MIME-Version: 1.0 To: Paul Schmehl References: <201203071740.q27HeCFT018574@freefall.freebsd.org> In-Reply-To: <201203071740.q27HeCFT018574@freefall.freebsd.org> X-Enigmail-Version: 1.3.5 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (mouf.net [204.109.58.86]); Sat, 17 Mar 2012 18:53:01 -0400 (EDT) X-Virus-Scanned: clamav-milter 0.97.2 at mouf.net X-Virus-Status: Clean Cc: perl@FreeBSD.org Subject: Re: ports/165826: [PATCH] net/p5-Net-Nessus-XMLRPC: add missing DEPENDS X-BeenThere: freebsd-perl@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: maintainer of a number of perl-related ports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 17 Mar 2012 22:53:02 -0000 On 03/07/12 12:40, Paul Schmehl wrote: > > According to the CPAN page > (), > only IO::Socket::SSL is required (and in FreeBSD, Net::SSL is a RUN_DEPENDS > for IO::Socket::SSL. anyway.) > > "'This CPAN module uses LWP for communicating with Nessus over XMLRPC via > https. Therefore, make sure that you have Net::SSL (provided by > Crypt::SSLeay): http://search.cpan.org/perldoc?Crypt::SSLeay or > IO::Socket::SSL: http://search.cpan.org/perldoc?IO::Socket::SSL" > > If you want to argue that LWP is a RUN_DEPENDS, I can see that, but why > HTML::Message and XML::Simple? Why does the author think these other > modules are required? > > I need more information before making this change. Unfortunately, the documentation doesn't match the code. I found these by running "make test" with just the package installed (in a chroot). Looking at the code: ./work/Net-Nessus-XMLRPC-0.30/lib/Net/Nessus/XMLRPC.pm:use HTTP::Request::Common; hence the dep on HTML::Message. Similarly: ./work/Net-Nessus-XMLRPC-0.30/lib/Net/Nessus/XMLRPC.pm:use XML::Simple; hence the dep on XML::Simple. > Even if these other modules were required, they wouldn't be BUILD_DEPENDS, > they would be RUN_DEPENDS, so the patch would need to be corrected for that. The "build" will complain that these modules are missing at build time: ===> Configuring for p5-Net-Nessus-XMLRPC-0.30 Warning: prerequisite HTTP::Request::Common 0 not found. Warning: prerequisite LWP::UserAgent 0 not found. Warning: prerequisite XML::Simple 0 not found. I like to avoid those warnings so that if, for example, an update to the module requires a new module I can see it easily instead of comparing that list to the RUN_DEPENDS to see if any are missing. >From a package standpoint it makes no difference if they're also BUILD_DEPENDS because they're going to be RUN_DEPENDS anyway and from a ports (building from source) perspective, it's cleaner, easier to see new depends, let's you run "make test" if you want and less worrisome for the uninformed. Steve