Date: Sun, 11 Nov 2001 12:11:01 +0000 From: Timo Geusch <freebsd@unix-consult.com> To: current@freebsd.org Subject: NFS rpc.lockd bug in nfs client mode - patch attached. Message-ID: <20011111121101.A875@odie.unix-consult.com>
next in thread | raw e-mail | index | archive | help
--7AUc2qLy4jB3hD7Z
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
All,
I'm running -current on my main box, NFS mounting home directories from my
-stable box. The -current box is configured as an NFS client only as it does
not serve anything. The -stable box is configured as an NFS server only.
In this configuration, running rpc.statd and rpc.lockd on both boxes (manually
started on the -current box as it does not support rpc.lockd & statd via
/etc/rc in nfs client mode[1]), rpc.lockd core dumps reliably on the -current
client when unlocking a file on the server.
I have tracked this down as a problem with too few parameters being passed to
lock_answer (file kern.c). The attached patch fixes the problem for me by
bringing the parameters in line with the other calls to lock_answer.
Can someone with commit priviledges please review the patch and commit it if
it does the right thing?
Thanks,
Timo
[1] I can supply a rough patch to fix this problem, but I'm not happy with it.
If someone is interested in reviewing the patch, please drop me an email and
I'll get it off to you.
--7AUc2qLy4jB3hD7Z
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment; filename="lock_proc.diff"
--- lock_proc.c.old Sun Oct 14 19:36:35 2001
+++ lock_proc.c Sun Nov 11 11:57:35 2001
@@ -763,7 +763,7 @@
if (debug_level)
log_from_addr("nlm_unlock_res", rqstp);
- lock_answer(&arg->cookie, arg->stat.stat, NLM_VERS);
+ lock_answer(-1, &arg->cookie, arg->stat.stat, NULL, NLM_VERS);
return (NULL);
}
--7AUc2qLy4jB3hD7Z--
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20011111121101.A875>