Date: Thu, 26 Feb 2009 10:01:25 +0900 From: Pyun YongHyeon <pyunyh@gmail.com> To: freebsd-stable@freebsd.org Subject: Re: fun with if_re Message-ID: <20090226010125.GC63173@michelle.cdnetworks.co.kr> In-Reply-To: <20090223115412.GO79003@e-Gitt.NET> References: <20090204100507.5f223d9e.gerrit@pmp.uni-hannover.de> <20090204104655.GA73543@michelle.cdnetworks.co.kr> <20090205085812.b2deb1f7.gerrit@pmp.uni-hannover.de> <20090205082804.GD77461@michelle.cdnetworks.co.kr> <20090213101910.a126c14d.gerrit@pmp.uni-hannover.de> <20090213102400.GD12653@michelle.cdnetworks.co.kr> <20090213114143.a77f1acb.gerrit@pmp.uni-hannover.de> <20090213113955.GE12653@michelle.cdnetworks.co.kr> <20090223115412.GO79003@e-Gitt.NET>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Feb 23, 2009 at 12:54:12PM +0100, Oliver Brandmueller wrote: > Hi, > > On Fri, Feb 13, 2009 at 08:39:55PM +0900, Pyun YongHyeon wrote: > > Ok, try attached patch. > > > Index: sys/dev/re/if_re.c > > =================================================================== > > --- sys/dev/re/if_re.c (revision 187352) > > +++ sys/dev/re/if_re.c (working copy) > > @@ -158,6 +158,8 @@ > > /* Tunables. */ > [...] > > This seems to have fixed a regression I found after the latest re > changes. While the changes lead to a situation, where the re interface > (as opposed to before) seems to always attach, I had the problem that > after 1-2 days it failed (sorry, was just about to investigate when I > tried your patch and thus didn't write down the error message > associated). > > With your patch my re seems to be running fine for the last days now. > That's odd. The patch just revert register mapping method for RTL8169SC family as memory mapped register access seems to have problems on RTL8169SC controllers. From the output below I think your controller is RTL8168C PCIe controller so the patch has no effect on your controller. Would you tell me more details on your issue? CURRENT has more robust code for PCIe based controllers so how about giving it a try on stable/7? Just copying if_re.c/if_rl.c/if_rlreg.h from HEAD to stable/7 should work. > re0@pci0:4:0:0: class=0x020000 card=0x392c1462 chip=0x816810ec rev=0x02 hdr=0x00 > vendor = 'Realtek Semiconductor' > device = 'RTL8168/8111 PCI-E Gigabit Ethernet NIC' > class = network > subclass = ethernet > > re0: <RealTek 8168/8168B/8168C/8168CP/8168D/8111B/8111C/8111CP PCIe Gigabit Ethernet> port 0xd800-0xd8ff mem 0xfeaff000-0xfeafffff,0xf8ff0000-0xf8ffffff irq 18 at device 0.0 on pci4 > re0: Chip rev. 0x3c000000 > re0: MAC rev. 0x00400000 > miibus0: <MII bus> on re0 > rgephy0: <RTL8169S/8110S/8211B media interface> PHY 1 on miibus0 > rgephy0: 10baseT, 10baseT-FDX, 100baseTX, 100baseTX-FDX, 1000baseT, 1000baseT-FDX, auto > re0: Ethernet address: 00:21:85:1e:8b:c9 > re0: [FILTER] >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20090226010125.GC63173>