Date: Mon, 4 Jun 2001 15:20:02 -0700 (PDT) From: Will Andrews <will@physics.purdue.edu> To: freebsd-ports@FreeBSD.org Subject: Re: ports/27877: New port: net/konverse (jabber client for kde) Message-ID: <200106042220.f54MK2N21768@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR ports/27877; it has been noted by GNATS.
From: Will Andrews <will@physics.purdue.edu>
To: perky@python.or.kr
Cc: freebsd-gnats-submit@FreeBSD.ORG
Subject: Re: ports/27877: New port: net/konverse (jabber client for kde)
Date: Mon, 4 Jun 2001 17:15:52 -0500
On Mon, Jun 04, 2001 at 11:46:30AM -0700, perky@python.or.kr (perky@python.or.kr) wrote:
> # konverse/files/patch-configure
It's better to patch configure.in where possible.
> XUSE_KDELIBS_VER=2
> XUSE_QT_VER= 2
The former implies the latter.
> XCONFIGURE_ARGS+=--with-extra-includes=${LOCALBASE}/include \
> X --x-includes=${X11BASE}/include \
> X --x-libraries=${X11BASE}/lib \
> X --prefix=${PREFIX}
--prefix comes with GNU_CONFIGURE=yes.
> X-konverse_LDADD = $(top_builddir)/konverse/expat/libexpat.a -ldl -lkdeui -lkdecore -lqt -lXext -lX11 $(LIBSOCKET)
> X+konverse_LDADD = $(top_builddir)/konverse/expat/libexpat.a -lkdeui -lkdecore -lqt2 -lXext -lX11 $(LIBSOCKET)
This kind of patch is better done with a regex in the Makefile.
> X- QDateTime retVal = dt.addSecs( -1 * timezone );
> X+ QDateTime retVal = dt.addSecs( -1 * local->tm_gmtoff );
[...]
> X- QDateTime dt = source.addSecs( timezone );
> X+ QDateTime dt = source.addSecs( local->tm_gmtoff );
See above.
> X-LIBQT="-lqt"
[...]
> X- try="ls -1 $dir/libqt.*"
> X+ try="ls -1 $dir/libqt2.*"
[...]
> X-LIBS="-lqt -lXext -lX11 $LIBSOCKET"
> X+LIBS="${LIBQT} -lXext -lX11 $LIBSOCKET"
[...]
> X-LIB_QT='-lqt $(LIBPNG) $(LIBJPEG) -lXext $(LIB_X11) $(LIBSM)'
> X+LIB_QT='${LIBQT} $(LIBPNG) $(LIBJPEG) -lXext $(LIB_X11) $(LIBSM)'
Again. Although "-lqt" --> "$(LIBQT)" is a little harder to do
in regex, it's not impossible. :)
--
wca
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200106042220.f54MK2N21768>