Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 4 Sep 2014 02:24:12 +0400
From:      Dmitry Marakasov <amdmi3@amdmi3.ru>
To:        Adam Weinberger <adamw@FreeBSD.org>
Cc:        svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org
Subject:   Re: svn commit: r362826 - head/games/xrot
Message-ID:  <20140903222412.GB43982@hades.panopticon>
In-Reply-To: <201407241624.s6OGO5CS028298@svn.freebsd.org>
References:  <201407241624.s6OGO5CS028298@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
* Adam Weinberger (adamw@FreeBSD.org) wrote:

Was there a reason for a sticky bit and u+w on a binary? If no, I'd
like to change it to more common and expectable 2555.

> Author: adamw
> Date: Thu Jul 24 16:24:05 2014
> New Revision: 362826
> URL: http://svnweb.freebsd.org/changeset/ports/362826
> QAT: https://qat.redports.org/buildarchive/r362826/
> 
> Log:
>   Stage, and move pkg-install into the plist to handle modifying
>   files outside of $PREFIX correctly.
> 
> Added:
>   head/games/xrot/pkg-plist   (contents, props changed)
> Deleted:
>   head/games/xrot/pkg-install
> Modified:
>   head/games/xrot/Makefile
> 
> Modified: head/games/xrot/Makefile
> ==============================================================================
> --- head/games/xrot/Makefile	Thu Jul 24 16:22:57 2014	(r362825)
> +++ head/games/xrot/Makefile	Thu Jul 24 16:24:05 2014	(r362826)
> @@ -23,13 +23,9 @@ USE_XORG=	xpm
>  ALL_TARGET=	xrot
>  CFLAGS+=	-Wno-return-type
>  
> -PLIST_FILES=	bin/xrot
> -
> -NO_STAGE=	yes
>  do-install:
> -	${INSTALL_PROGRAM} ${WRKSRC}/xrot ${PREFIX}/bin
> -	${CHOWN} root:games ${PREFIX}/bin/xrot
> -	${CHMOD} g+s ${PREFIX}/bin/xrot
> -	${SH} pkg-install ${PKGNAME} POST-INSTALL
> +	${INSTALL_PROGRAM} ${WRKSRC}/xrot ${STAGEDIR}${PREFIX}/bin
> +	@${MKDIR} ${STAGEDIR}/var/games
> +	${TOUCH} ${STAGEDIR}/var/games/xrot.scores.sample
>  
>  .include <bsd.port.mk>
> 
> Added: head/games/xrot/pkg-plist
> ==============================================================================
> --- /dev/null	00:00:00 1970	(empty, because file is newly added)
> +++ head/games/xrot/pkg-plist	Thu Jul 24 16:24:05 2014	(r362826)
> @@ -0,0 +1,9 @@
> +@group games
> +@mode 3755
> +bin/xrot
> +@mode
> +@cwd /
> +@sample var/games/xrot.scores.sample
> +@exec chmod 664 %B/%f
> +@group
> +@dirrmtry var/games

-- 
Dmitry Marakasov   .   55B5 0596 FF1E 8D84 5F56  9510 D35A 80DD F9D2 F77D
amdmi3@amdmi3.ru  ..:  jabber: amdmi3@jabber.ru    http://www.amdmi3.ru



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20140903222412.GB43982>