From owner-svn-ports-all@FreeBSD.ORG Thu Sep 25 12:41:51 2014 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id E5A419E; Thu, 25 Sep 2014 12:41:51 +0000 (UTC) Received: from mailrelay008.isp.belgacom.be (mailrelay008.isp.belgacom.be [195.238.6.174]) by mx1.freebsd.org (Postfix) with ESMTP id 0FC3F89E; Thu, 25 Sep 2014 12:41:50 +0000 (UTC) X-Belgacom-Dynamic: yes X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ApYGAO8IJFRbsISZ/2dsb2JhbABggw5TV8pqh04CgQgXAXuEBAEBBDocHgUQCw4GBAklDyoeBhOIQgEIwmQBF494JgeESwEElhqHCIFjk3SDZTsvgkoBAQE Received: from 153.132-176-91.adsl-dyn.isp.belgacom.be (HELO kalimero.tijl.coosemans.org) ([91.176.132.153]) by relay.skynet.be with ESMTP; 25 Sep 2014 14:41:42 +0200 Received: from kalimero.tijl.coosemans.org (kalimero.tijl.coosemans.org [127.0.0.1]) by kalimero.tijl.coosemans.org (8.14.9/8.14.9) with ESMTP id s8PCfTc9003966; Thu, 25 Sep 2014 14:41:41 +0200 (CEST) (envelope-from tijl@FreeBSD.org) Date: Thu, 25 Sep 2014 14:41:29 +0200 From: Tijl Coosemans To: John Marino Subject: Re: svn commit: r369236 - in head/science: ghemical libghemical libint mpqc Message-ID: <20140925144129.4706e81e@kalimero.tijl.coosemans.org> In-Reply-To: <5423FE5D.8070209@marino.st> References: <201409251104.s8PB43lY004283@svn.freebsd.org> <20140925133254.150c9351@kalimero.tijl.coosemans.org> <5423FE5D.8070209@marino.st> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, John Marino , ports-committers@freebsd.org X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Sep 2014 12:41:52 -0000 On Thu, 25 Sep 2014 13:37:01 +0200 John Marino wrote: > On 9/25/2014 13:32, Tijl Coosemans wrote: >> On Thu, 25 Sep 2014 11:04:03 +0000 (UTC) John Marino wrote: >>> Author: marino >>> Date: Thu Sep 25 11:04:02 2014 >>> New Revision: 369236 >>> URL: http://svnweb.freebsd.org/changeset/ports/369236 >>> QAT: https://qat.redports.org/buildarchive/r369236/ >>> >>> Log: >>> When science/mpqc was staged, it utilized libtool which renumbered all >>> the library versions from 8.0.1 to 7.1.0. This was caused by the age >>> component being greater than 0. By patching configure.in with a new >>> version, we can generate major SHLIB of 8 again. While here, fix the >>> bin/sc-config tool to remove a bad include cflag. >> >> Please revert this bit. Upstream sets 8:0:1 so it should get 8:0:1. >> There's no need for us to change that. > > The previous commit changes all the extensions from 8.0.1 to 7.1.0. > This puts it back to how it was before. The libtool caused a regression > (it's not the first time I've run into this) so this commit fixes that > regression manually. The extension was .so.8 and the previous commit changed it into .so.7.1.0. That is not a regression. It is supposed to work like that. That's how libtool works on Linux, Darwin and a number of other systems and USES=libtool makes it work like that on FreeBSD as well. The advantage of this new version scheme is that the major number doesn't change as much. In the new scheme these libraries are still at version 7 and have not been bumped to 8 yet like in the old scheme. This is a good thing. Fewer changes to the major version means fewer cases where dependent ports need a PORTREVISION bump.