Date: Fri, 25 May 2018 13:08:54 -0700 From: Bryan Drewery <bdrewery@FreeBSD.org> To: Matt Macy <mmacy@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r334128 - in head: . lib/libpmcstat lib/libpmcstat/pmu-events lib/libpmcstat/pmu-events/arch lib/libpmcstat/pmu-events/arch/arm64 lib/libpmcstat/pmu-events/arch/arm64/arm lib/libpmcstat... Message-ID: <cce1ce1c-91a5-f664-6b68-ac631970728b@FreeBSD.org> In-Reply-To: <201805240430.w4O4U6Js001134@repo.freebsd.org> References: <201805240430.w4O4U6Js001134@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --5A7xcxOCbMT9DXKZfXWZcU8v889phVa5o Content-Type: multipart/mixed; boundary="nLTYkr8l3ZYwmGdN808jGQfO2df1OzYio"; protected-headers="v1" From: Bryan Drewery <bdrewery@FreeBSD.org> To: Matt Macy <mmacy@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Message-ID: <cce1ce1c-91a5-f664-6b68-ac631970728b@FreeBSD.org> Subject: Re: svn commit: r334128 - in head: . lib/libpmcstat lib/libpmcstat/pmu-events lib/libpmcstat/pmu-events/arch lib/libpmcstat/pmu-events/arch/arm64 lib/libpmcstat/pmu-events/arch/arm64/arm lib/libpmcstat... References: <201805240430.w4O4U6Js001134@repo.freebsd.org> In-Reply-To: <201805240430.w4O4U6Js001134@repo.freebsd.org> --nLTYkr8l3ZYwmGdN808jGQfO2df1OzYio Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 5/23/2018 9:30 PM, Matt Macy wrote: > Author: mmacy > Date: Thu May 24 04:30:06 2018 > New Revision: 334128 > URL: https://svnweb.freebsd.org/changeset/base/334128 >=20 > Log: > libpmcstat: compile in events based on json description >=20 > Added: > head/lib/libpmcstat/libpmcstat_pmu_util.c (contents, props changed)= > head/lib/libpmcstat/pmu-events/ > head/lib/libpmcstat/pmu-events/Makefile (contents, props changed) =2E.. > # cat lib/libpmcstat/pmu-events/Makefile > # $FreeBSD$ >=20 > PROG=3Djevents > SRCS=3Djevents.c jsmn.c json.c > CFLAGS+=3D -Wno-cast-qual > .PATH: ${.CURDIR} > build-tools: jevents > MAN=3D > .include <bsd.prog.mk> Several things wrong here and in lib/libpmcstat/Makefile 1. Newlines? Existing style from other Makefiles? style.Makefile(5) 2. .PATH implicitly has .CURDIR in it already. 3. Need special META_MODE handling for the build-tools target. I don't necessarily expect people to get this right but every other use of build-tools in the tree has a pattern that isn't used here. 4. You used HOST_OBJTOP in lib/libpmcstat/Makefile to refer to jevents for some reason when nothing else does. This is really just the META_MODE pattern being wrong. I'm fixing all of this. --=20 Regards, Bryan Drewery --nLTYkr8l3ZYwmGdN808jGQfO2df1OzYio-- --5A7xcxOCbMT9DXKZfXWZcU8v889phVa5o Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJbCG1WAAoJEDXXcbtuRpfP76YH/0Vxv6knMWSVssAb/SMNY8yr PqpAaqVAEWZVnmizQXC3QBY8cRGNxHc28q218FSRfLBIuAeDSU0wTQbFi/1ekxv4 nv+ThkPKqsQGWTv9z/q4nUfFUSzqIUES+y4oI5ezoxQBNJQKB8kL4NPLYzAcajTa dWcZSC9g4Y9gTPbayIN+SiOXZpuAsTIMW7USHbe1LQ6LqdMELchKPcSJbJAOY94n 19BEoD1wQHlECVldpVuFtpAMVDBPQDRTpp33RdHWT3ovKWnH5pvBHvjdqVrJH73S f/Be4rsw0vmBJLeiOddUQlF+KwmcaUfidMsoBzzhuXKyLwiyx0e0z9/tmicAgIk= =5eOP -----END PGP SIGNATURE----- --5A7xcxOCbMT9DXKZfXWZcU8v889phVa5o--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?cce1ce1c-91a5-f664-6b68-ac631970728b>